chrome/app/settings_strings.grdp - Issue 2147933004: Fix password detail dialog so it doesn't imply save functionality.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/app/settings_strings.grdp

Issue 2147933004: Fix password detail dialog so it doesn't imply save functionality. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/app/settings_strings.grdp

diff --git a/chrome/app/settings_strings.grdp b/chrome/app/settings_strings.grdp

index 6e5d76a53f4717df023cd9c5625761e22946e0b4..897945a3066cdc0c11e1e95c4e35388b638913ea 100644

--- a/chrome/app/settings_strings.grdp

+++ b/chrome/app/settings_strings.grdp

@@ -293,14 +293,17 @@

Delete this item

</message>

- <message name="IDS_SETTINGS_PASSWORD_EDIT" desc="Label for a context menu item that shows a dialog with edit options for the selected password." meaning="Edit selected password.">

- Edit

+ <message name="IDS_SETTINGS_PASSWORD_DONE" desc="Label for a button that dismisses the password details dialog.">

tommycli 2016/07/15 18:52:29 Nit: Should this be re-ordered below "Saved passwo

hcarmona 2016/07/15 19:03:48 No objections. Done.

+ Done

+ </message>

+ <message name="IDS_SETTINGS_PASSWORD_VIEW_DETAILS" desc="Label for a context menu item that shows a dialog with details for the selected password.">

+ View details

</message>

- Remove

+ Remove

</message>

- <message name="IDS_SETTINGS_PASSWORDS_EDIT_TITLE" desc="Title for the 'Edit saved password' dialog. This dialog lets a user see a saved password and copy the username.">

- Edit saved password

+ <message name="IDS_SETTINGS_PASSWORDS_VIEW_DETAILS_TITLE" desc="Title for the dialog that shows password details. This dialog lets a user see a saved password and copy the username.">

+ Saved password details

</message>

Website

« no previous file with comments | « no previous file | chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html » ('j') | no next file with comments »