Issue 2147933002: Remove AppBanner runtime flag (status=stable)

Issue 2147933002: Remove AppBanner runtime flag (status=stable) (Closed)

Created:
4 years, 5 months ago by rwlbuis

Modified:
4 years, 5 months ago

Reviewers:
benwells, Mike West

CC:
blink-reviews, chromium-reviews, dominickn+watch_chromium.org, haraken, kinuko+watch, mlamouri+watch-blink_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Remove AppBanner runtime flag (status=stable) BUG=402536 Committed: https://crrev.com/5f9ae975c6d36883e44ff5e43127abea282b15d5 Cr-Commit-Position: refs/heads/master@{#405464}

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -10 lines)			Patch
M	third_party/WebKit/Source/modules/app_banner/AppBannerController.cpp	View	2 chunks	+0 lines, -3 lines	0 comments	Download
M	third_party/WebKit/Source/modules/app_banner/AppBannerPromptResult.idl	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	third_party/WebKit/Source/modules/app_banner/BeforeInstallPromptEvent.idl	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	third_party/WebKit/Source/web/WebLocalFrameImpl.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 11 (5 generated)

rwlbuis

PTAL, this has been stable for more than a year so I assume it is ...

4 years, 5 months ago (2016-07-13 15:42:29 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2147933002/1

4 years, 5 months ago (2016-07-14 08:55:59 UTC) #6

commit-bot: I haz the power

4 years, 5 months ago (2016-07-14 10:27:53 UTC) #11

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/5f9ae975c6d36883e44ff5e43127abea282b15d5
Cr-Commit-Position: refs/heads/master@{#405464}