Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 2147933002: Remove AppBanner runtime flag (status=stable) (Closed)

Created:
4 years, 5 months ago by rwlbuis
Modified:
4 years, 5 months ago
Reviewers:
benwells, Mike West
CC:
blink-reviews, chromium-reviews, dominickn+watch_chromium.org, haraken, kinuko+watch, mlamouri+watch-blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove AppBanner runtime flag (status=stable) BUG=402536 Committed: https://crrev.com/5f9ae975c6d36883e44ff5e43127abea282b15d5 Cr-Commit-Position: refs/heads/master@{#405464}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -10 lines) Patch
M third_party/WebKit/Source/modules/app_banner/AppBannerController.cpp View 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/app_banner/AppBannerPromptResult.idl View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/app_banner/BeforeInstallPromptEvent.idl View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
rwlbuis
PTAL, this has been stable for more than a year so I assume it is ...
4 years, 5 months ago (2016-07-13 15:42:29 UTC) #3
Mike West
LGTM.
4 years, 5 months ago (2016-07-14 07:36:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2147933002/1
4 years, 5 months ago (2016-07-14 08:55:59 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-14 10:25:55 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-14 10:26:01 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 10:27:53 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5f9ae975c6d36883e44ff5e43127abea282b15d5
Cr-Commit-Position: refs/heads/master@{#405464}

Powered by Google App Engine
This is Rietveld 408576698