Source/core/html/MediaDocument.cpp - Issue 214793005: Use HTMLMediaElement::togglePlayState() where appropriate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/MediaDocument.cpp

Issue 214793005: Use HTMLMediaElement::togglePlayState() where appropriate (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/MediaDocument.cpp

diff --git a/Source/core/html/MediaDocument.cpp b/Source/core/html/MediaDocument.cpp

index 4e007c30752e62c1c4bd97ae92bee146181d8f5b..69a110b5d5a786a559f17b665b31f1d1140b954f 100644

--- a/Source/core/html/MediaDocument.cpp

+++ b/Source/core/html/MediaDocument.cpp

@@ -142,11 +142,7 @@ void MediaDocument::defaultEventHandler(Event* event)

KeyboardEvent* keyboardEvent = toKeyboardEvent(event);

if (keyboardEvent->keyIdentifier() == "U+0020" || keyboardEvent->keyCode() == VKEY_MEDIA_PLAY_PAUSE) {

// space or media key (play/pause)

- if (video->paused()) {

- if (video->canPlay())

- video->play();

- } else

- video->pause();

+ video->togglePlayState();

event->setDefaultHandled();

}