Use HTMLMediaElement::togglePlayState() where appropriate

Source/core/html/HTMLMediaElement.h

Index: Source/core/html/HTMLMediaElement.h
diff --git a/Source/core/html/HTMLMediaElement.h b/Source/core/html/HTMLMediaElement.h
index 774308fab390b5468fe3d0816d30e96d9a606a4f..fc949c77638491c6f5e5d0364439652a3442b535 100644
--- a/Source/core/html/HTMLMediaElement.h
+++ b/Source/core/html/HTMLMediaElement.h
@@ -126,7 +126,7 @@ public:
     virtual double currentTime() const OVERRIDE FINAL;
     virtual void setCurrentTime(double, ExceptionState&) OVERRIDE FINAL;
     virtual double duration() const OVERRIDE FINAL;
-    virtual bool paused() const OVERRIDE FINAL;
+    bool paused() const;
     double defaultPlaybackRate() const;
     void setDefaultPlaybackRate(double);
     double playbackRate() const;
@@ -138,8 +138,8 @@ public:
     bool autoplay() const;
     bool loop() const;
     void setLoop(bool b);
-    virtual void play() OVERRIDE FINAL;
-    virtual void pause() OVERRIDE FINAL;
+    void play();
+    void pause();
 
     // statistics
     unsigned webkitAudioDecodedByteCount() const;
@@ -157,8 +157,7 @@ public:
     virtual bool muted() const OVERRIDE FINAL;
     virtual void setMuted(bool) OVERRIDE FINAL;
 
-    virtual bool canPlay() const OVERRIDE FINAL;
-
+    bool togglePlayStateWillPlay() const;

[acolwell GONE FROM CHROMIUM, 2014/03/28 01:02:52]

nit: How about togglePlayStateWillTriggerPlay() or a descriptive comment here
that indiciates something similar.

[philipj_slow, 2014/03/28 07:22:23]

I added a comment to explain briefly what these two functions are for, I hope
that's better.

     void togglePlayState();
 
     PassRefPtr<TextTrack> addTextTrack(const AtomicString& kind, const AtomicString& label, const AtomicString& language, ExceptionState&);