Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 2147883003: Revert of Reland Implement .eh_frame writer and disassembler. (Closed)

Created:
4 years, 5 months ago by Michael Hablich
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@eh-frame-base
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Reland Implement .eh_frame writer and disassembler. (patchset #74 id:2070001 of https://codereview.chromium.org/2023503002/ ) Reason for revert: Blocks roll https://codereview.chromium.org/2148743003/ See https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/244252/steps/compile%20%28with%20patch%29/logs/stdio for error message Original issue's description: > Reland Implement .eh_frame writer and disassembler. > > Original commit message: > > Also, CodeGenerator::MakeCodeEpilogue now accepts an optional pointer > to a EhFrameWriter and will attach unwinding information to the code > object when passed one. > > Reason for reverting: > > The STATIC_CONST_MEMBER_DEFINITION in eh-frame-writer-unittest.cc > causes a compiler error on V8 Win64 - clang buildbot. > > Removing that bit. > > BUG=v8:4899 > LOG=N > > Committed: https://crrev.com/b413f0ebe1a5dde016bfb94bb80bf872ebc24372 > Cr-Commit-Position: refs/heads/master@{#37707} TBR=rmcilroy@chromium.org,jarin@chromium.org,ssanfilippo@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4899 Committed: https://crrev.com/f4ba2a483e447dcc0c62336f04e56d2fd4aed3e1 Cr-Commit-Position: refs/heads/master@{#37717}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+216 lines, -1655 lines) Patch
M BUILD.gn View 3 chunks +0 lines, -3 lines 0 comments Download
D src/arm/eh-frame-arm.cc View 1 chunk +0 lines, -67 lines 0 comments Download
D src/arm64/eh-frame-arm64.cc View 1 chunk +0 lines, -72 lines 0 comments Download
M src/codegen.h View 2 chunks +1 line, -2 lines 0 comments Download
M src/codegen.cc View 3 chunks +1 line, -3 lines 0 comments Download
M src/compiler/code-generator.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/crankshaft/lithium.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/eh-frame.h View 1 chunk +19 lines, -275 lines 0 comments Download
M src/eh-frame.cc View 1 chunk +79 lines, -617 lines 0 comments Download
M src/full-codegen/full-codegen.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/objects.cc View 2 chunks +0 lines, -9 lines 0 comments Download
M src/perf-jit.cc View 2 chunks +12 lines, -7 lines 0 comments Download
M src/v8.gyp View 3 chunks +0 lines, -3 lines 0 comments Download
D src/x64/eh-frame-x64.cc View 1 chunk +0 lines, -66 lines 0 comments Download
M test/cctest/cctest.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A test/cctest/test-eh-frame-hdr.cc View 1 chunk +100 lines, -0 lines 0 comments Download
D test/unittests/eh-frame-iterator-unittest.cc View 1 chunk +0 lines, -61 lines 0 comments Download
D test/unittests/eh-frame-writer-unittest.cc View 1 chunk +0 lines, -464 lines 0 comments Download
M test/unittests/unittests.gyp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Michael Hablich
Created Revert of Reland Implement .eh_frame writer and disassembler.
4 years, 5 months ago (2016-07-13 14:15:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2147883003/1
4 years, 5 months ago (2016-07-13 14:15:26 UTC) #3
commit-bot: I haz the power
Failed to apply patch for src/codegen.cc: While running git apply --index -3 -p1; error: patch ...
4 years, 5 months ago (2016-07-13 14:15:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2147883003/1
4 years, 5 months ago (2016-07-13 14:19:36 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-13 14:20:32 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 14:23:52 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f4ba2a483e447dcc0c62336f04e56d2fd4aed3e1
Cr-Commit-Position: refs/heads/master@{#37717}

Powered by Google App Engine
This is Rietveld 408576698