Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: content/renderer/gpu/compositor_output_surface.cc

Issue 2147873003: cc: Dedup IPCs to return resources to client (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add bool is_swap_ack + remove CompositorFrameAck Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/gpu/compositor_output_surface.cc
diff --git a/content/renderer/gpu/compositor_output_surface.cc b/content/renderer/gpu/compositor_output_surface.cc
index a240b19736e1d0ce8c85197b9b6102cbfe2e005a..2128e93f2af8a8fc90e093e71e6bf9cf673ec948 100644
--- a/content/renderer/gpu/compositor_output_surface.cc
+++ b/content/renderer/gpu/compositor_output_surface.cc
@@ -12,7 +12,6 @@
#include "base/threading/thread_task_runner_handle.h"
#include "build/build_config.h"
#include "cc/output/compositor_frame.h"
-#include "cc/output/compositor_frame_ack.h"
#include "cc/output/managed_memory_policy.h"
#include "cc/output/output_surface_client.h"
#include "content/common/gpu/client/context_provider_command_buffer.h"
@@ -139,8 +138,8 @@ void CompositorOutputSurface::OnMessageReceived(const IPC::Message& message) {
IPC_BEGIN_MESSAGE_MAP(CompositorOutputSurface, message)
IPC_MESSAGE_HANDLER(ViewMsg_UpdateVSyncParameters,
OnUpdateVSyncParametersFromBrowser);
- IPC_MESSAGE_HANDLER(ViewMsg_SwapCompositorFrameAck, OnSwapAck);
- IPC_MESSAGE_HANDLER(ViewMsg_ReclaimCompositorResources, OnReclaimResources);
+ IPC_MESSAGE_HANDLER(ViewMsg_ReclaimCompositorResources,
+ OnReclaimCompositorResources);
IPC_END_MESSAGE_MAP()
}
@@ -155,24 +154,17 @@ void CompositorOutputSurface::OnUpdateVSyncParametersFromBrowser(
client_->CommitVSyncParameters(timebase, interval);
}
-void CompositorOutputSurface::OnSwapAck(uint32_t output_surface_id,
- const cc::CompositorFrameAck& ack) {
- // Ignore message if it's a stale one coming from a different output surface
- // (e.g. after a lost context).
- if (output_surface_id != output_surface_id_)
- return;
- ReclaimResources(&ack);
- client_->DidSwapBuffersComplete();
-}
-
-void CompositorOutputSurface::OnReclaimResources(
+void CompositorOutputSurface::OnReclaimCompositorResources(
uint32_t output_surface_id,
- const cc::CompositorFrameAck& ack) {
+ bool is_swap_ack,
+ const cc::ReturnedResourceArray& resources) {
// Ignore message if it's a stale one coming from a different output surface
// (e.g. after a lost context).
if (output_surface_id != output_surface_id_)
return;
- ReclaimResources(&ack);
+ ReclaimResources(resources);
+ if (is_swap_ack)
+ client_->DidSwapBuffersComplete();
}
bool CompositorOutputSurface::Send(IPC::Message* message) {

Powered by Google App Engine
This is Rietveld 408576698