Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(758)

Issue 2147873002: Revert of ImageCapture: Implement takePhoto() for Mac AVFoundation (Closed)

Created:
4 years, 5 months ago by henrika (OOO until Aug 14)
Modified:
4 years, 5 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, mcasas+watch+vc_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of ImageCapture: Implement takePhoto() for Mac AVFoundation (patchset #4 id:220001 of https://codereview.chromium.org/2129733004/ ) Reason for revert: Most likely breaks WebRtcWebcamBrowserTests/WebRtcWebcamBrowserTest.MANUAL_TestAcquiringAndReacquiringWebcam/0 on the WebRTC in Chrome bots. See https://build.chromium.org/p/chromium.webrtc/builders/Mac%20Tester/builds/56889/steps/browser_tests/logs/stdio for details. Original issue's description: > ImageCapture: Implement takePhoto() for Mac AVFoundation > > By pulling the necessary symbols out of AVFoundation > and using them; most notably (Cr)AVCaptureStillImageOutput. > > TakePhoto is already implemented for Android (both APIs). > > Also adding VideoCaptureDeviceTest::MAYBE_TakePhoto > test case, enabled only for Mac. > > BUG=518807 > TEST=Run build with flag --enable-blink-features=ImageCapture, > navigate to [1] and push buttons > - Open Camera ... > - Create ImageCapturer > - takePhoto() (N times!) --> profit > > [1] https://rawgit.com/Miguelao/demos/master/imagecapture.html > > Committed: https://crrev.com/ad75c34fbb7940127a99be04ed6019ab09d73880 > Cr-Commit-Position: refs/heads/master@{#404832} TBR=rsesek@chromium.org,emircan@chromium.org,sandersd@chromium.org,mcasas@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=518807 Committed: https://crrev.com/a8ee6ab59eae20ded3a64e5384048b107a8b9024 Cr-Commit-Position: refs/heads/master@{#405071}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -224 lines) Patch
M media/base/mac/avfoundation_glue.h View 5 chunks +6 lines, -19 lines 0 comments Download
M media/base/mac/avfoundation_glue.mm View 1 chunk +0 lines, -4 lines 0 comments Download
M media/base/mac/coremedia_glue.h View 1 chunk +0 lines, -1 line 0 comments Download
M media/capture/video/mac/video_capture_device_avfoundation_mac.h View 4 chunks +2 lines, -10 lines 0 comments Download
M media/capture/video/mac/video_capture_device_avfoundation_mac.mm View 6 chunks +13 lines, -72 lines 0 comments Download
M media/capture/video/mac/video_capture_device_mac.h View 2 chunks +1 line, -13 lines 0 comments Download
M media/capture/video/mac/video_capture_device_mac.mm View 3 chunks +2 lines, -31 lines 0 comments Download
M media/capture/video/video_capture_device_unittest.cc View 10 chunks +12 lines, -74 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
henrika (OOO until Aug 14)
Created Revert of ImageCapture: Implement takePhoto() for Mac AVFoundation
4 years, 5 months ago (2016-07-13 07:33:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2147873002/1
4 years, 5 months ago (2016-07-13 07:34:26 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-13 07:35:13 UTC) #5
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-13 07:35:23 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 07:36:54 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a8ee6ab59eae20ded3a64e5384048b107a8b9024
Cr-Commit-Position: refs/heads/master@{#405071}

Powered by Google App Engine
This is Rietveld 408576698