Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 2147853002: ui: Correctly add children for the ViewAndroid tree. (Closed)

Created:
4 years, 5 months ago by khushalsagar
Modified:
4 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ui: Correctly add children for the ViewAndroid tree. When adding a new child to a ViewAndroid, it tries to remove the child from the parent of the View to which the child is being added rather than removing it from its existing parent. Fix that. Committed: https://crrev.com/080e5fbd61be3ffca3da15a9edcd38ca2a74413d Cr-Commit-Position: refs/heads/master@{#405251}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ui/android/view_android.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
Khushal
4 years, 5 months ago (2016-07-13 01:31:14 UTC) #2
David Trainor- moved to gerrit
lgtm
4 years, 5 months ago (2016-07-13 17:15:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2147853002/1
4 years, 5 months ago (2016-07-13 17:20:51 UTC) #5
no sievers
oops, lgtm thanks!
4 years, 5 months ago (2016-07-13 17:57:40 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-13 20:06:12 UTC) #7
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-13 20:07:02 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 20:07:53 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/080e5fbd61be3ffca3da15a9edcd38ca2a74413d
Cr-Commit-Position: refs/heads/master@{#405251}

Powered by Google App Engine
This is Rietveld 408576698