Fixing WebView ProGuard config for annotations

android_webview/apk/java/proguard.flags

 # Don't rename anything, it makes stack traces unintelligible. We only allow the
 # obfuscation pass to run so that we can discard attributes like local variable
 # tables.
 -keepnames class *** { *; }
 
 # Keep source file and line number information for stack traces.
 -keepattributes SourceFile,LineNumberTable
 
 # Keep all runtime visible annotations.
 -keepattributes RuntimeVisibleAnnotations
-
-# Disable optimization as this causes proguard to remove seemingly random stuff,
-# including things explicitly kept in this configuration.
--dontoptimize
+# Keeping annotations - if we remove these keeps, ProGuard will eliminate the
+# annotations themselves, which will prevent them from affecting ProGuard's
+# optimization run.
+-keep @interface **.AccessedBy*

[Torne, 2016/07/13 16:54:25]

It seems like the names here should actually match the ones used in the -keep
directives and not be globbed differently. Can you make them match one way or
the other?

[smaier, 2016/07/13 22:21:23]

Done.

+-keep @interface **.CalledBy*
+-keep @interface **.RemovableInRelease
+-keep @interface **.UsedBy*
 
 # Keep the factory and its public members; it's the main entry point used by the
 # framework.
 -keep class com.android.webview.chromium.WebViewChromiumFactoryProvider {
     public *;
 }
 
 # This is the main entry point for APIs. It is kept to make developing with
 # unreleased Android easier.
 -keep class com.android.webview.chromium.WebViewChromium {
   public *;
 }
 
 # Keep JNI interfaces.
 -keepclasseswithmembers class com.android.webview.chromium.**,org.chromium.** {
   @**.AccessedByNative <fields>;
 }
 -keepclasseswithmembers class com.android.webview.chromium.**,org.chromium.** {
   @**.CalledByNative <methods>;
 }
 -keepclasseswithmembers class com.android.webview.chromium.**,org.chromium.** {
   @**.CalledByNativeUnchecked <methods>;
 }
 -keepclasseswithmembers class com.android.webview.chromium.**,org.chromium.** {
   native <methods>;
 }
 
-# Keep things explicitly marked as used by reflection
+# Keep classes marked as used by reflection
+-keep @**.UsedByReflection class *

[Torne, 2016/07/13 16:54:25]

This isn't consistent with the other class wildcards in here - either everything
should be *, or everything should be just the two package prefixes, not a
mixture?

[smaier, 2016/07/13 22:21:23]

Done.

+
+# Keep members explicitly marked as used by reflection
 -keepclasseswithmembers class com.android.webview.chromium.**,org.chromium.** {
   @**.UsedByReflection *;
 }
 
+# Remove methods annotated with this if their return value is unused
+-assumenosideeffects class ** {
+  @org.chromium.base.annotations.RemovableInRelease <methods>;
+}
+
 # Linker dynamically casts to $TestRunner when running tests. We don't run these
 # tests in WebView.
 -dontnote org.chromium.base.library_loader.Linker$TestRunner
 
 # Don't note about the API 21 compatibility code which references various
 # hidden APIs via reflection.
 -dontnote com.android.webview.chromium.WebViewDelegateFactory$Api21CompatibilityDelegate
 
 # DefaultAndroidKeyStore uses reflection to access internal OpenSSL state.
 -dontnote org.chromium.net.DefaultAndroidKeyStore
@@ skipping 35 matching lines @@
 -dontnote android.support.**
 -dontwarn android.support.**
 
 # Keep all enum values and valueOf methods. See
 # http://proguard.sourceforge.net/index.html#manual/examples.html
 # for the reason for this. Also, see http://crbug.com/248037.
 -keepclassmembers enum * {
     public static **[] values();
     public static ** valueOf(java.lang.String);
 }