Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2147733004:
Remove chrome::NOTIFICATION_INSTANT_TAB_SUPPORT_DETERMINED (Closed)
|
Created:
4 years, 5 months ago by Marc Treib Modified:
4 years, 3 months ago CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove chrome::NOTIFICATION_INSTANT_TAB_SUPPORT_DETERMINED
It's not used anywhere anymore.
TBR=thestig@chromium.org
for removed notification in chrome_notification_types.h
BUG=627747
Committed: https://crrev.com/4576c724184e9507c3426be22c4808f021be35e9
Cr-Commit-Position: refs/heads/master@{#416610}
Patch Set 1 #Patch Set 2 : rebase #
Messages
Total messages: 24 (16 generated)
The CQ bit was checked by treib@chromium.org to run a CQ dry run
treib@chromium.org changed reviewers: + jered@chromium.org
PTAL!
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org to run a CQ dry run
Dry run: This issue passed the CQ dry run.
On 2016/07/13 10:20:14, Marc Treib wrote: > PTAL! lgtm It's been many years, but I seem to recall we added this to make the uitests work reliably, instead of racing tab creation. I'll take your word for it that it's no longer needed, though.
On 2016/07/13 14:06:06, Jered wrote: > On 2016/07/13 10:20:14, Marc Treib wrote: > > PTAL! > > lgtm > > It's been many years, but I seem to recall we added this to make the uitests > work reliably, instead of racing tab creation. I'll take your word for it that > it's no longer needed, though. I haven't done more to verify this than run the tests and see that nothing fails :) I'll investigate a bit more before committing, thanks!
The CQ bit was checked by treib@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Remove chrome::NOTIFICATION_INSTANT_TAB_SUPPORT_DETERMINED It's not used anywhere (except for some tests) BUG=627747 ========== to ========== Remove chrome::NOTIFICATION_INSTANT_TAB_SUPPORT_DETERMINED It's not used anywhere anymore. BUG=627747 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2016/07/13 14:24:14, Marc Treib wrote: > On 2016/07/13 14:06:06, Jered wrote: > > On 2016/07/13 10:20:14, Marc Treib wrote: > > > PTAL! > > > > lgtm > > > > It's been many years, but I seem to recall we added this to make the uitests > > work reliably, instead of racing tab creation. I'll take your word for it that > > it's no longer needed, though. > > I haven't done more to verify this than run the tests and see that nothing fails > :) > I'll investigate a bit more before committing, thanks! It's been a while, but in the meantime, all tests that used this notification have been either changed or removed. So I'm going to land this now :)
Description was changed from ========== Remove chrome::NOTIFICATION_INSTANT_TAB_SUPPORT_DETERMINED It's not used anywhere anymore. BUG=627747 ========== to ========== Remove chrome::NOTIFICATION_INSTANT_TAB_SUPPORT_DETERMINED It's not used anywhere anymore. TBR=thestig@chromium.org for removed notification in chrome_notification_types.h BUG=627747 ==========
The CQ bit was checked by treib@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from jered@chromium.org Link to the patchset: https://codereview.chromium.org/2147733004/#ps20001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Remove chrome::NOTIFICATION_INSTANT_TAB_SUPPORT_DETERMINED It's not used anywhere anymore. TBR=thestig@chromium.org for removed notification in chrome_notification_types.h BUG=627747 ========== to ========== Remove chrome::NOTIFICATION_INSTANT_TAB_SUPPORT_DETERMINED It's not used anywhere anymore. TBR=thestig@chromium.org for removed notification in chrome_notification_types.h BUG=627747 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Remove chrome::NOTIFICATION_INSTANT_TAB_SUPPORT_DETERMINED It's not used anywhere anymore. TBR=thestig@chromium.org for removed notification in chrome_notification_types.h BUG=627747 ========== to ========== Remove chrome::NOTIFICATION_INSTANT_TAB_SUPPORT_DETERMINED It's not used anywhere anymore. TBR=thestig@chromium.org for removed notification in chrome_notification_types.h BUG=627747 Committed: https://crrev.com/4576c724184e9507c3426be22c4808f021be35e9 Cr-Commit-Position: refs/heads/master@{#416610} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/4576c724184e9507c3426be22c4808f021be35e9 Cr-Commit-Position: refs/heads/master@{#416610}
Message was sent while issue was closed.
thestig@chromium.org changed reviewers: + thestig@chromium.org
Message was sent while issue was closed.
LGTM, but please remember to add those TBR'd to the reviewers list, so they know to review. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
