Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Issue 214773004: Fix crash in MemoryCache::replace. (Closed)

Created:
6 years, 9 months ago by Nate Chapin
Modified:
6 years, 9 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, gavinp+loader_chromium.org
Visibility:
Public.

Description

Fix crash in MemoryCache::replace. It's possible that MemoryCache::replace will try to evict a resource that has already been evicted. If there is another resource present in its place, it won't get evicted, but will get partially overwritten. In that partial overwrite, we leave references to it in the LRU lists, leading to later crashes. BUG=357174 TEST=MemoryCacheTest.RemoveDuringRevalidation Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170217

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -17 lines) Patch
M Source/core/fetch/MemoryCache.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/fetch/MemoryCache.cpp View 7 chunks +23 lines, -15 lines 0 comments Download
M Source/core/fetch/MemoryCacheTest.cpp View 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
Nate Chapin
6 years, 9 months ago (2014-03-27 17:55:18 UTC) #1
abarth-chromium
LGTM yay for unit tests
6 years, 9 months ago (2014-03-27 21:05:19 UTC) #2
Nate Chapin
On 2014/03/27 21:05:19, abarth wrote: > LGTM > > yay for unit tests I know, ...
6 years, 9 months ago (2014-03-27 21:08:22 UTC) #3
Nate Chapin
The CQ bit was checked by japhet@chromium.org
6 years, 9 months ago (2014-03-27 21:08:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/japhet@chromium.org/214773004/1
6 years, 9 months ago (2014-03-27 21:09:06 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 21:26:10 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_compile_dbg
6 years, 9 months ago (2014-03-27 21:26:11 UTC) #7
Nate Chapin
The CQ bit was checked by japhet@chromium.org
6 years, 9 months ago (2014-03-27 21:33:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/japhet@chromium.org/214773004/1
6 years, 9 months ago (2014-03-27 21:33:27 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 22:33:05 UTC) #10
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 9 months ago (2014-03-27 22:33:06 UTC) #11
Nate Chapin
The CQ bit was checked by japhet@chromium.org
6 years, 9 months ago (2014-03-27 22:59:43 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/japhet@chromium.org/214773004/1
6 years, 9 months ago (2014-03-27 22:59:49 UTC) #13
commit-bot: I haz the power
6 years, 9 months ago (2014-03-27 23:00:19 UTC) #14
Message was sent while issue was closed.
Change committed as 170217

Powered by Google App Engine
This is Rietveld 408576698