[Findit] Make sure not use empty list or dict as default value.

appengine/findit/model/wf_swarming_task.py

Index: appengine/findit/model/wf_swarming_task.py
diff --git a/appengine/findit/model/wf_swarming_task.py b/appengine/findit/model/wf_swarming_task.py
index 88107889460b5b82b97867e4002c7325758c10d8..384859264a02e51bac8c80ab08338e623fb68a02 100644
--- a/appengine/findit/model/wf_swarming_task.py
+++ b/appengine/findit/model/wf_swarming_task.py
@@ -20,7 +20,7 @@ class WfSwarmingTask(BaseBuildModel):
 
   # A dict to keep track of running information for each test:
   # number of total runs, number of each status (such as 'SUCCESS' or 'FAILED')
-  tests_statuses = ndb.JsonProperty(default={}, indexed=False, compressed=True)
+  tests_statuses = ndb.JsonProperty(indexed=False, compressed=True)
 
   # The status of the swarming task.
   status = ndb.IntegerProperty(
@@ -37,7 +37,7 @@ class WfSwarmingTask(BaseBuildModel):
   completed_time = ndb.DateTimeProperty(indexed=False)
 
   # parameters need to be stored and analyzed later.
-  parameters = ndb.JsonProperty(default={}, indexed=False, compressed=True)
+  parameters = ndb.JsonProperty(indexed=False, compressed=True)
 
   @property
   def classified_tests(self):
@@ -74,9 +74,14 @@ class WfSwarmingTask(BaseBuildModel):
   @staticmethod
   def Create(
       master_name, builder_name, build_number, step_name):  # pragma: no cover
-    return WfSwarmingTask(
+    task = WfSwarmingTask(
         key=WfSwarmingTask._CreateKey(
             master_name, builder_name, build_number, step_name))
+    if task.parameters is None:
+      task.parameters = {}

[stgao, 2016/07/12 21:09:12]

Could be simplified as below. Same for others.

  task.parameters = task.parameters or {}

BTW, do we need to check here right after creation?

[lijeffrey, 2016/07/12 21:15:39]

+1, since default={} has been removed, shouldn't these be None upon creation?

If it's safe to remove these then this code can be simplified furher to just

return WfSwarmingTask(key=...)

[chanli, 2016/07/12 23:45:45]

This change is to make sure we can directly add data to the dict without
checking if it's None first. 

[stgao, 2016/07/13 06:51:31]

Upon creation, the values are always None though.

[chanli, 2016/07/13 17:53:38]

Yes, it just we don't need to always check if they are None when using them,
especially when adding data to them.

+    if task.tests_statuses is None:
+      task.tests_statuses = {}
+    return task
 
   @staticmethod
   def Get(