Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 2147713002: [Findit] Make sure not use empty list or dict as default value. (Closed)

Created:
4 years, 5 months ago by chanli
Modified:
4 years, 5 months ago
Reviewers:
stgao, lijeffrey
CC:
chromium-reviews, infra-reviews+infra_chromium.org
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

[Findit] Make sure not use empty list or dict as default value. BUG= Committed: https://chromium.googlesource.com/infra/infra/+/d7b4ad09657c9aad5536eebef063669a99900e63

Patch Set 1 #

Total comments: 5

Patch Set 2 : . #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -7 lines) Patch
M appengine/findit/model/wf_swarming_task.py View 1 2 3 chunks +6 lines, -3 lines 0 comments Download
M appengine/findit/model/wf_try_job.py View 1 2 2 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
chanli
ptal
4 years, 5 months ago (2016-07-12 20:55:51 UTC) #2
stgao
lgtm with nits. https://codereview.chromium.org/2147713002/diff/1/appengine/findit/model/wf_swarming_task.py File appengine/findit/model/wf_swarming_task.py (right): https://codereview.chromium.org/2147713002/diff/1/appengine/findit/model/wf_swarming_task.py#newcode81 appengine/findit/model/wf_swarming_task.py:81: task.parameters = {} Could be simplified ...
4 years, 5 months ago (2016-07-12 21:09:12 UTC) #3
lijeffrey
https://codereview.chromium.org/2147713002/diff/1/appengine/findit/model/wf_swarming_task.py File appengine/findit/model/wf_swarming_task.py (right): https://codereview.chromium.org/2147713002/diff/1/appengine/findit/model/wf_swarming_task.py#newcode81 appengine/findit/model/wf_swarming_task.py:81: task.parameters = {} On 2016/07/12 21:09:12, stgao wrote: > ...
4 years, 5 months ago (2016-07-12 21:15:39 UTC) #4
chanli
https://codereview.chromium.org/2147713002/diff/1/appengine/findit/model/wf_swarming_task.py File appengine/findit/model/wf_swarming_task.py (right): https://codereview.chromium.org/2147713002/diff/1/appengine/findit/model/wf_swarming_task.py#newcode81 appengine/findit/model/wf_swarming_task.py:81: task.parameters = {} On 2016/07/12 21:15:39, lijeffrey wrote: > ...
4 years, 5 months ago (2016-07-12 23:45:45 UTC) #5
chanli
4 years, 5 months ago (2016-07-13 00:12:54 UTC) #6
lijeffrey
lgtm
4 years, 5 months ago (2016-07-13 00:15:51 UTC) #7
stgao
https://codereview.chromium.org/2147713002/diff/1/appengine/findit/model/wf_swarming_task.py File appengine/findit/model/wf_swarming_task.py (right): https://codereview.chromium.org/2147713002/diff/1/appengine/findit/model/wf_swarming_task.py#newcode81 appengine/findit/model/wf_swarming_task.py:81: task.parameters = {} On 2016/07/12 23:45:45, chanli wrote: > ...
4 years, 5 months ago (2016-07-13 06:51:31 UTC) #8
chanli
https://codereview.chromium.org/2147713002/diff/1/appengine/findit/model/wf_swarming_task.py File appengine/findit/model/wf_swarming_task.py (right): https://codereview.chromium.org/2147713002/diff/1/appengine/findit/model/wf_swarming_task.py#newcode81 appengine/findit/model/wf_swarming_task.py:81: task.parameters = {} On 2016/07/13 06:51:31, stgao wrote: > ...
4 years, 5 months ago (2016-07-13 17:53:38 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2147713002/40001
4 years, 5 months ago (2016-07-19 18:07:24 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-19 18:24:21 UTC) #14
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/infra/infra/+/d7b4ad09657c9aad5536eebef0636...

Powered by Google App Engine
This is Rietveld 408576698