Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 21477002: Introduce PopReturnAddressTo and PushReturnAddressFrom macro-assembler instructions for X64 (Closed)

Created:
7 years, 4 months ago by haitao.feng
Modified:
7 years, 4 months ago
Reviewers:
danno
CC:
v8-dev
Visibility:
Public.

Description

Introduce PopReturnAddressTo and PushReturnAddressFrom macro-assembler instructions for X64 R=danno@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16034

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -80 lines) Patch
M src/x64/builtins-x64.cc View 7 chunks +14 lines, -14 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 14 chunks +25 lines, -28 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/ic-x64.cc View 11 chunks +22 lines, -22 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/macro-assembler-x64.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M src/x64/stub-cache-x64.cc View 6 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
haitao.feng
Both X64 and X32 use 8-byte push/pop for return address operation. For others, such as ...
7 years, 4 months ago (2013-08-01 05:49:31 UTC) #1
danno
lgtm
7 years, 4 months ago (2013-08-02 08:55:04 UTC) #2
haitao.feng
7 years, 4 months ago (2013-08-02 13:42:22 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r16034 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698