Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 2147693004: [heap] ObjectStats: Fix accounting for fixed array subtypes (Closed)

Created:
4 years, 5 months ago by Michael Lippautz
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] ObjectStats: Fix accounting for fixed array subtypes - Fix recording sub types that have their own instance type - Fix double accounting by keeping a shadow map for tracking recorded status - Add recording of more fixed array sub types BUG=hpayer@chromium.org Committed: https://crrev.com/fee58583916efe968c19ec905529d563974025d8 Cr-Commit-Position: refs/heads/master@{#37768}

Patch Set 1 #

Patch Set 2 : Fix accounting. #

Patch Set 3 : Filter out dupes #

Total comments: 2

Patch Set 4 : More fixed array types #

Unified diffs Side-by-side diffs Delta from patch set Stats (+174 lines, -90 lines) Patch
M src/heap/mark-compact.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/heap/mark-compact.cc View 1 3 chunks +16 lines, -11 lines 0 comments Download
M src/heap/marking.h View 1 2 chunks +0 lines, -2 lines 0 comments Download
M src/heap/object-stats.h View 1 2 3 4 chunks +13 lines, -2 lines 0 comments Download
M src/heap/object-stats.cc View 1 2 3 10 chunks +130 lines, -69 lines 0 comments Download
M src/objects.h View 1 2 3 1 chunk +13 lines, -4 lines 0 comments Download

Messages

Total messages: 23 (16 generated)
Michael Lippautz
4 years, 5 months ago (2016-07-14 09:54:45 UTC) #4
Michael Lippautz
https://codereview.chromium.org/2147693004/diff/40001/src/heap/mark-compact.cc File src/heap/mark-compact.cc (right): https://codereview.chromium.org/2147693004/diff/40001/src/heap/mark-compact.cc#newcode339 src/heap/mark-compact.cc:339: RecordObjectStats(); It's important to record after clearing non-live references ...
4 years, 5 months ago (2016-07-14 09:56:17 UTC) #5
Hannes Payer (out of office)
lgtm
4 years, 5 months ago (2016-07-14 11:51:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2147693004/60001
4 years, 5 months ago (2016-07-14 14:38:48 UTC) #18
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 5 months ago (2016-07-14 14:41:09 UTC) #20
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-14 14:41:12 UTC) #21
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 14:43:15 UTC) #23
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/fee58583916efe968c19ec905529d563974025d8
Cr-Commit-Position: refs/heads/master@{#37768}

Powered by Google App Engine
This is Rietveld 408576698