Struct traits used by GpuInfo

mojo/common/common_custom_types.typemap

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 mojom = "//mojo/common/common_custom_types.mojom"
 public_headers = [
   "//base/files/file_path.h",
   "//base/values.h",
   "//base/time/time.h",
+  "//base/version.h",
 ]
-traits_headers = [ "//ipc/ipc_message_utils.h" ]
+traits_headers = [
+  "//ipc/ipc_message_utils.h",
+  "//mojo/common/common_custom_types_struct_traits.h",
+]
+sources = [

[Ken Rockot(use gerrit already), 2016/07/27 20:05:25]

Do not add sources to typemaps.

Please create a new source_set target like
//mojo/common:common_custom_struct_traits and add the cc and h files to its
sources. Then add that target to public_deps below.

[Alex Z., 2016/07/28 19:40:44]

I have found sources in other typemap files. For example,
https://cs.chromium.org/chromium/src/cc/ipc/quads.typemap?q=_struct_traits.cc....
Is there any particular reason why sources shouldn't be in typemaps?

[Ken Rockot(use gerrit already), 2016/07/28 19:46:36]

Hmm. I didn't think we supported this, but mojom.gni clearly does read sources
from the typemap. Nevermind :)

+  "//mojo/common/common_custom_types_struct_traits.cc",
+]
 public_deps = [
   "//ipc",
 ]
 
 type_mappings = [
   "mojo.common.mojom.FilePath=base::FilePath",
   "mojo.common.mojom.DictionaryValue=base::DictionaryValue",
   "mojo.common.mojom.ListValue=base::ListValue",
   "mojo.common.mojom.Time=base::Time[copyable_pass_by_value]",
   "mojo.common.mojom.TimeDelta=base::TimeDelta[copyable_pass_by_value]",
   "mojo.common.mojom.TimeTicks=base::TimeTicks[copyable_pass_by_value]",
+  "mojo.common.mojom.Version=base::Version",
 ]