Struct traits used by GpuInfo

mojo/common/common_custom_types_struct_traits.cc

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "mojo/common/common_custom_types_struct_traits.h"
+
+#include <iterator>
+
+#include "base/version.h"
+
+namespace mojo {
+
+namespace {
+
+std::string ConstructVersionString(const std::vector<uint32_t>& components) {

[Fady Samuel, 2016/07/19 17:33:03]

I just looked at base::Version's constructor. It seems really silly to construct
a string from a vector only to convert it back to a vector. I would give
base::Version a move-only constructor

[Alex Z., 2016/07/26 14:38:55]

Done.

+  std::stringstream version_stream;
+  for (size_t i = 0; i < components.size(); i++) {
+    if (i != 0)
+      version_stream << ".";
+
+    version_stream << components[i];
+  }
+  return version_stream.str();
+}
+
+}  // namespace
+
+// static
+const std::vector<uint32_t>&
+StructTraits<mojo::common::mojom::Version, base::Version>::components(
+    const base::Version& version) {
+  return version.components();
+}
+
+// static
+bool StructTraits<mojo::common::mojom::Version, base::Version>::Read(
+    mojo::common::mojom::VersionDataView data,
+    base::Version* out) {
+  std::vector<uint32_t> components;
+  if (!data.ReadComponents(&components))
+    return false;
+
+  *out = base::Version(ConstructVersionString(components));
+  return out->IsValid();
+}
+
+}  // namespace mojo