Issue 2147683002: Inline white-listed intrinsics also in AOT compilation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2147683002: Inline white-listed intrinsics also in AOT compilation. (Closed)

Created:
4 years, 5 months ago by Florian Schneider

Modified:
4 years, 5 months ago

Reviewers:
rmacnak

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Inline white-listed intrinsics also in AOT compilation. We don't inline intrinsics to produce smaller code, but for small methods (array length getters, etc.) we should do it because the code actually gets smaller by inlining, plus we get better type/range information. BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/aec015a5809308b8acb39de605e59b14ce396956

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	runtime/vm/flow_graph_inliner.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download
	M	runtime/vm/method_recognizer.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

Florian Schneider

4 years, 5 months ago (2016-07-12 20:59:43 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
aec015a5809308b8acb39de605e59b14ce396956 (presubmit successful).