Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Unified Diff: gpu/command_buffer/service/program_manager.h

Issue 2147663002: program_manager: detect interface block mismatches (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/command_buffer/service/program_manager.h
diff --git a/gpu/command_buffer/service/program_manager.h b/gpu/command_buffer/service/program_manager.h
index 734e50fc03b5f8cdad588617af8b141725d7d5f4..a735023765e40b878f88eb0238539bf9749fa5e3 100644
--- a/gpu/command_buffer/service/program_manager.h
+++ b/gpu/command_buffer/service/program_manager.h
@@ -345,6 +345,10 @@ class GPU_EXPORT Program : public base::RefCounted<Program> {
// conflicting_name if such cases are detected.
bool DetectUniformsMismatch(std::string* conflicting_name) const;
+ // Detects if there are interface blocks of the same name but different
+ // layouts.
+ bool DetectInterfaceBlocksMismatch(std::string* conflicting_name) const;
+
// Return true if a varying is statically used in fragment shader, but it
// is not declared in vertex shader.
bool DetectVaryingsMismatch(std::string* conflicting_name) const;
« no previous file with comments | « no previous file | gpu/command_buffer/service/program_manager.cc » ('j') | gpu/command_buffer/service/program_manager.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698