Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2147663002:
program_manager: detect interface block mismatches (Closed)
|
Created:
4 years, 5 months ago by Corentin Wallez Modified:
4 years, 5 months ago CC:
chromium-reviews, piman+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptionprogram_manager: detect interface block mismatches
This fixes the deqp/data/gles3/shaders/linkage.html tests that were
checking that compilation fail if interface blocks have different
layouts.
BUG=621031
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
Committed: https://crrev.com/e4feb0d482d7b795afe2257ef8f304c4c1428151
Cr-Commit-Position: refs/heads/master@{#405256}
Patch Set 1 #
Total comments: 1
Messages
Total messages: 22 (7 generated)
Description was changed from ========== program_manager: detect interface block mismatches This fixes the deqp/data/gles3/shaders/linkage.html tests that were checking that compilation fail if interface blocks have different layouts. BUG=621031 ========== to ========== program_manager: detect interface block mismatches This fixes the deqp/data/gles3/shaders/linkage.html tests that were checking that compilation fail if interface blocks have different layouts. BUG=621031 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ==========
cwallez@chromium.org changed reviewers: + kbr@chromium.org, zmo@chromium.org
PTAL, I will CQ this only once https://chromium-review.googlesource.com/c/359607/ is rolled in.
On 2016/07/12 19:45:12, Corentin Wallez wrote: > PTAL, I will CQ this only once > https://chromium-review.googlesource.com/c/359607/ is rolled in. LGTM Can you remove the webgl2 expectation in this CL?
On 2016/07/12 at 19:55:55, zmo wrote: > On 2016/07/12 19:45:12, Corentin Wallez wrote: > > PTAL, I will CQ this only once > > https://chromium-review.googlesource.com/c/359607/ is rolled in. > > LGTM > > Can you remove the webgl2 expectation in this CL? The test will still be failing because one subtest is only fixed by the corresponding WebGL PR. (if it is landed before this lands I'll add the suppression here)
LGTM if this passes tests, but one question. https://codereview.chromium.org/2147663002/diff/1/gpu/command_buffer/service/... File gpu/command_buffer/service/program_manager.cc (right): https://codereview.chromium.org/2147663002/diff/1/gpu/command_buffer/service/... gpu/command_buffer/service/program_manager.cc:1644: if (hit->second->isSameInterfaceBlockAtLinkTime(it.second)) Is isSameInterfaceBlockAtLinkTime a new method in InterfaceBlock? I was curious to see how it worked and found it doesn't seem to be there.
On 2016/07/12 at 20:37:13, kbr wrote: > LGTM if this passes tests, but one question. > > https://codereview.chromium.org/2147663002/diff/1/gpu/command_buffer/service/... > File gpu/command_buffer/service/program_manager.cc (right): > > https://codereview.chromium.org/2147663002/diff/1/gpu/command_buffer/service/... > gpu/command_buffer/service/program_manager.cc:1644: if (hit->second->isSameInterfaceBlockAtLinkTime(it.second)) > Is isSameInterfaceBlockAtLinkTime a new method in InterfaceBlock? I was curious to see how it worked and found it doesn't seem to be there. Indeed, see https://chromium-review.googlesource.com/c/359607/
On 2016/07/12 20:48:21, Corentin Wallez wrote: > On 2016/07/12 at 20:37:13, kbr wrote: > > LGTM if this passes tests, but one question. > > > > > https://codereview.chromium.org/2147663002/diff/1/gpu/command_buffer/service/... > > File gpu/command_buffer/service/program_manager.cc (right): > > > > > https://codereview.chromium.org/2147663002/diff/1/gpu/command_buffer/service/... > > gpu/command_buffer/service/program_manager.cc:1644: if > (hit->second->isSameInterfaceBlockAtLinkTime(it.second)) > > Is isSameInterfaceBlockAtLinkTime a new method in InterfaceBlock? I was > curious to see how it worked and found it doesn't seem to be there. > > Indeed, see https://chromium-review.googlesource.com/c/359607/ Thanks, sorry I missed that in your initial comment.
qiankun.miao@intel.com changed reviewers: + qiankun.miao@intel.com
I tested this CL can make precision mis-matching for uniform block pass. I added a test: https://github.com/KhronosGroup/WebGL/pull/1875.
On 2016/07/13 at 08:23:19, qiankun.miao wrote: > I tested this CL can make precision mis-matching for uniform block pass. I added a test: https://github.com/KhronosGroup/WebGL/pull/1875. Relevant ANGLE change got rolled in, CQing.
The CQ bit was checked by cwallez@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_optional_gpu_tests_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)
The CQ bit was checked by cwallez@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Your CL relies on deprecated CQ feature(s): * Specifying master names without "master." prefix is deprecated: tryserver.chromium.linux, tryserver.chromium.mac, tryserver.chromium.win. For more details, see http://crbug.com/617627.
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
CQ bit was unchecked.
Message was sent while issue was closed.
Description was changed from ========== program_manager: detect interface block mismatches This fixes the deqp/data/gles3/shaders/linkage.html tests that were checking that compilation fail if interface blocks have different layouts. BUG=621031 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== program_manager: detect interface block mismatches This fixes the deqp/data/gles3/shaders/linkage.html tests that were checking that compilation fail if interface blocks have different layouts. BUG=621031 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/e4feb0d482d7b795afe2257ef8f304c4c1428151 Cr-Commit-Position: refs/heads/master@{#405256} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/e4feb0d482d7b795afe2257ef8f304c4c1428151 Cr-Commit-Position: refs/heads/master@{#405256} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
