Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2147643003: Replace undefined assert_undefined function. (Closed)

Created:
4 years, 5 months ago by suzyh_UTC10 (ex-contributor)
Modified:
4 years, 5 months ago
Reviewers:
nainar
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace undefined assert_undefined function. assert_undefined(v) was a convenience function for assert_equals(v, null) that was lost when merging player-unresolved-times.html with the W3C startTime.html test file in http://crrev.com/2141853002 BUG=623437 Committed: https://crrev.com/4e8c3bc91382a3a69b5ddf6287101a4d5f47f6c5 Cr-Commit-Position: refs/heads/master@{#405055}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M third_party/WebKit/LayoutTests/web-animations-api/startTime.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/web-animations-api/startTime-expected.txt View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
suzyh_UTC10 (ex-contributor)
Hey Naina, Sorry I didn't catch this when you did the original CL. PTAL!
4 years, 5 months ago (2016-07-13 04:57:00 UTC) #2
nainar
lgtm
4 years, 5 months ago (2016-07-13 05:01:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2147643003/1
4 years, 5 months ago (2016-07-13 05:01:59 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-13 06:24:42 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 06:28:24 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4e8c3bc91382a3a69b5ddf6287101a4d5f47f6c5
Cr-Commit-Position: refs/heads/master@{#405055}

Powered by Google App Engine
This is Rietveld 408576698