third_party/WebKit/LayoutTests/fast/files/file-constructor.html - Issue 2147633002: Remove nonstandard 'endings' option for Blob/File constructor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/files/file-constructor.html

Issue 2147633002: Remove nonstandard 'endings' option for Blob/File constructor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Layout test updates Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/fast/files/blob-constructor.html ('K') | « third_party/WebKit/LayoutTests/fast/files/blob-constructor-expected.txt ('k') | third_party/WebKit/LayoutTests/fast/files/file-constructor-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/files/file-constructor.html

diff --git a/third_party/WebKit/LayoutTests/fast/files/file-constructor.html b/third_party/WebKit/LayoutTests/fast/files/file-constructor.html

index f634db7d7750c47089f34b20d8028339ac706848..4b6c61db36f91a8077b642181c21c12cf412018a 100644

--- a/third_party/WebKit/LayoutTests/fast/files/file-constructor.html

+++ b/third_party/WebKit/LayoutTests/fast/files/file-constructor.html

@@ -9,8 +9,6 @@ shouldBeTrue("(new File([], 'world.html')) instanceof window.File");

shouldBeTrue("(new File(['hello'], 'world.html')) instanceof window.File");

shouldBeTrue("(new File(['hello'], 'world.html', {})) instanceof window.File");

shouldBeTrue("(new File(['hello'], 'world.html', {type:'text/html'})) instanceof window.File");

-shouldBeTrue("(new File(['hello'], 'world.html', {type:'text/html', endings:'native'})) instanceof window.File");

-shouldBeTrue("(new File(['hello'], 'world.html', {type:'text/html', endings:'transparent'})) instanceof window.File");

// Test that File inherits from File.

shouldBeTrue("(new File([], 'world.html')) instanceof window.File")

@@ -66,8 +64,8 @@ shouldThrow("(new File([], throwingObj)).name", "'Error'");

// Test some invalid property bags.

shouldBeTrue("(new File([], 'world.html', {unknownKey:'value'})) instanceof window.File"); // Ignore invalid keys

-shouldThrow("new File([], 'world.html', {endings:'illegalValue'})", "'TypeError: Failed to construct \\'File\\': The provided value \\'illegalValue\\' is not a valid enum value of type NormalizeLineEndings.'");

-shouldThrow("new File([], 'world.html', {endings:throwingObj})", "'Error'");

+shouldNotThrow("new File([], 'world.html', {endings:'illegalValue'})");

+shouldNotThrow("new File([], 'world.html', {endings:throwingObj})");

shouldThrow("new File([], 'world.html', {type:throwingObj})", "'Error'");

shouldThrow("new File([], 'world.html', {type:'hello\u00EE'})", "'SyntaxError: Failed to construct \\'File\\': The \\'type\\' property must consist of ASCII characters.'");