content/test/data/device_orientation/device_orientation_null_test.html - Issue 214763002: Add end-to-end browser tests for Device Motion/Orientation null-events.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/test/data/device_orientation/device_orientation_null_test.html

Issue 214763002: Add end-to-end browser tests for Device Motion/Orientation null-events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@March-24-null-firing-testing

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/test/data/device_orientation/device_motion_null_test.html ('K') | « content/test/data/device_orientation/device_motion_null_test.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/test/data/device_orientation/device_orientation_null_test.html

diff --git a/content/test/data/device_orientation/device_orientation_test.html b/content/test/data/device_orientation/device_orientation_null_test.html

similarity index 62%

copy from content/test/data/device_orientation/device_orientation_test.html

copy to content/test/data/device_orientation/device_orientation_null_test.html

index 95c68f553c86354602c867cdda05f1491caef544..b9758253e439e69590726c1dfd1d295f21d58ae0 100644

--- a/content/test/data/device_orientation/device_orientation_test.html

+++ b/content/test/data/device_orientation/device_orientation_null_test.html

@@ -1,14 +1,11 @@

<html>

<head>

- <title>DeviceOrientation test</title>

+ <title>DeviceOrientation all-null event test</title>

- var eventCount = 0;

function checkOrientationEvent(event) {

- // Return true iff the orientation is close enough to (1, 2, 3).

- return Math.abs(event.alpha - 1) < 0.01 &&

- Math.abs(event.beta - 2) < 0.01 &&

- Math.abs(event.gamma - 3) < 0.01;

+ return event.alpha == null &&

+ event.beta == null &&

+ event.gamma == null;

}

function onOrientation(event) {

@@ -28,9 +25,12 @@

function fail() {

document.location = '#fail';

}

+ window.addEventListener('deviceorientation', onOrientation);

+ alert("suspend active DOM objects");

</script>

</head>

- <body onLoad="window.addEventListener('deviceorientation', onOrientation)">

+ <body>

</body>

</html>