Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 2147593002: Make build/include_what_you_use more consistent (Closed)

Created:
4 years, 5 months ago by Luis Héctor Chávez
Modified:
4 years, 5 months ago
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make build/include_what_you_use more consistent This is a cherry-pick of https://github.com/google/styleguide/pull/158/ BUG=627202 TEST=cpplint_unittest.py Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/9b2173c4190b8fc39db3ed15e7281411013ce986

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M cpplint.py View 1 chunk +7 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Luis Héctor Chávez
PTAL dpranke for OWNERS erg for GitHub pull request review
4 years, 5 months ago (2016-07-12 15:59:13 UTC) #2
Dirk Pranke
lgtm
4 years, 5 months ago (2016-07-12 16:25:33 UTC) #3
Elliot Glaysher
(Merged on github)
4 years, 5 months ago (2016-07-13 17:16:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2147593002/1
4 years, 5 months ago (2016-07-13 17:16:52 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 17:20:10 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/9b2173c4190b8f...

Powered by Google App Engine
This is Rietveld 408576698