Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 2147583003: Removed keeps for unused member variables. (Closed)

Created:
4 years, 5 months ago by smaier
Modified:
4 years, 5 months ago
Reviewers:
agrieve
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removed keeps for unused member variables. When merging before submitting, this change did not make it into codereview.chromium.org/2070633002. As it stands, this CL reduces .dex size by 127kb and saves us 27kb of dirty memory per process. See paste.googleplex.com/6304692032241664 for what was removed. BUG=619937 Committed: https://crrev.com/1c20746e0de53e2f19f36cd6644c7537c094dbe3 Cr-Commit-Position: refs/heads/master@{#405156}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M chrome/android/java/proguard.flags View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
smaier
4 years, 5 months ago (2016-07-13 14:01:35 UTC) #4
agrieve
On 2016/07/13 14:01:35, smaier wrote: lgtm
4 years, 5 months ago (2016-07-13 14:52:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2147583003/1
4 years, 5 months ago (2016-07-13 15:11:00 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-13 15:15:57 UTC) #10
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-13 15:16:06 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 15:19:21 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1c20746e0de53e2f19f36cd6644c7537c094dbe3
Cr-Commit-Position: refs/heads/master@{#405156}

Powered by Google App Engine
This is Rietveld 408576698