Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Issue 2147573002: [turbofan] Respect catch prediction provided by parser. (Closed)

Created:
4 years, 5 months ago by Michael Starzinger
Modified:
4 years, 5 months ago
Reviewers:
neis
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Respect catch prediction provided by parser. This makes sure the {AstGraphBuilder} respects the catch-prediction that is provided by the parser along with each {TryStatement}. This is needed for try-blocks materialized by the parser not to influence predictions users expect when using the debugger. R=neis@chromium.org TEST=mjsunit/debug-exceptions BUG=v8:5183 Committed: https://crrev.com/08843650dbbcca05f4ecf8cf18ebc3001724f0a5 Cr-Commit-Position: refs/heads/master@{#37702}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -16 lines) Patch
M src/compiler/ast-graph-builder.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/compiler/ast-graph-builder.cc View 8 chunks +21 lines, -12 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Michael Starzinger
4 years, 5 months ago (2016-07-12 15:45:40 UTC) #1
neis
lgtm, thanks
4 years, 5 months ago (2016-07-12 17:17:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2147573002/1
4 years, 5 months ago (2016-07-13 07:48:40 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-13 08:11:02 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 08:13:27 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/08843650dbbcca05f4ecf8cf18ebc3001724f0a5
Cr-Commit-Position: refs/heads/master@{#37702}

Powered by Google App Engine
This is Rietveld 408576698