git cl try: Trigger CQ Dry Run by default.

git cl try: Trigger CQ Dry Run by default.

If bots are specified manually on command line OR in PRESUBMIT.py,
then old behavior remains, namely triggering just those bots.

Otherwise, git cl try will now trigger CQ Dry Run. This is a good
default and also resolves several bugs:

 * https://crbug.com/581150 where git cl try used to load cq.cfg
   from infra/config, but that's not always correct for all projects.

 * https://crbug.com/625697 where even if cq.cfg is in default location.
   it might be outdated.

 * https://crbug.com/585237 where git cl try would ignore special
   in CL description CQ_INCLUDE_TRYBOTS, which is processed by CQ,
   but not git cl try.

BUG=625697, 585237, 581150
R=sergiyb@chromium.org,emso@chromium.org

Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/9de9ec66b3a0b8f17dc8c15069add8f62b9796a6

[tandrii(chromium), 2016-07-12 22:51:50]

The CQ bit was checked by tandrii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-12 22:52:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tandrii(chromium), 2016-07-12 22:52:36]

The CQ bit was unchecked by tandrii@chromium.org

[tandrii(chromium), 2016-07-12 22:52:44]

The CQ bit was checked by tandrii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-12 22:52:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tandrii(chromium), 2016-07-12 22:54:09]

The CQ bit was checked by tandrii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-12 22:54:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-12 22:55:20]

The CQ bit was unchecked by commit-bot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-12 22:55:21]

Dry run: This issue passed the CQ dry run.

[tandrii(chromium), 2016-07-12 22:57:35]

The CQ bit was checked by tandrii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-12 22:57:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-12 23:01:16]

The CQ bit was unchecked by commit-bot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-12 23:01:17]

Dry run: This issue passed the CQ dry run.

[Paweł Hajdan Jr., 2016-07-13 09:55:45]

phajdan.jr@chromium.org changed reviewers:
+ phajdan.jr@chromium.org

[Paweł Hajdan Jr., 2016-07-13 09:55:46]

LGTM w/optional suggestion

https://codereview.chromium.org/2147563003/diff/20001/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/2147563003/diff/20001/git_cl.py#newcode4589
git_cl.py:4589: except:
I'd usually catch Exception here, with no need then to explicitly mention
KeyboardInterrupt. Up to you.

[tandrii(chromium), 2016-07-13 09:57:51]

https://codereview.chromium.org/2147563003/diff/20001/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/2147563003/diff/20001/git_cl.py#newcode4589
git_cl.py:4589: except:
On 2016/07/13 09:55:46, Paweł Hajdan Jr. wrote:
> I'd usually catch Exception here, with no need then to explicitly mention
> KeyboardInterrupt. Up to you.

the purpose of explicitly mentioning Keyboard interrupt is to avoid printing
warning below.

[tandrii(chromium), 2016-07-13 09:58:03]

The CQ bit was checked by tandrii@chromium.org

[commit-bot: I haz the power, 2016-07-13 09:58:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 10:02:03]

Description was changed from

==========
git cl try: Trigger CQ Dry Run by default.

If bots are specified manually on command line OR in PRESUBMIT.py,
then old behavior remains, namely triggering just those bots.

Otherwise, git cl try will now trigger CQ Dry Run. This is a good
default and also resolves several bugs:

 * https://crbug.com/581150 where git cl try used to load cq.cfg
   from infra/config, but that's not always correct for all projects.

 * https://crbug.com/625697 where even if cq.cfg is in default location.
   it might be outdated.

 * https://crbug.com/585237 where git cl try would ignore special
   in CL description CQ_INCLUDE_TRYBOTS, which is processed by CQ,
   but not git cl try.

BUG=625697,585237,581150
R=sergiyb@chromium.org,emso@chromium.org
==========

to

==========
git cl try: Trigger CQ Dry Run by default.

If bots are specified manually on command line OR in PRESUBMIT.py,
then old behavior remains, namely triggering just those bots.

Otherwise, git cl try will now trigger CQ Dry Run. This is a good
default and also resolves several bugs:

 * https://crbug.com/581150 where git cl try used to load cq.cfg
   from infra/config, but that's not always correct for all projects.

 * https://crbug.com/625697 where even if cq.cfg is in default location.
   it might be outdated.

 * https://crbug.com/585237 where git cl try would ignore special
   in CL description CQ_INCLUDE_TRYBOTS, which is processed by CQ,
   but not git cl try.

BUG=625697,585237,581150
R=sergiyb@chromium.org,emso@chromium.org

Committed:
https://chromium.googlesource.com/chromium/tools/depot_tools/+/9de9ec66b3a0b8...
==========

[commit-bot: I haz the power, 2016-07-13 10:02:04]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/9de9ec66b3a0b8...