chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabDelegateFactory.java - Issue 2147543003: Check if there is a url before checking to launch activity inside CCT

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabDelegateFactory.java

Issue 2147543003: Check if there is a url before checking to launch activity inside CCT (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: mariakhomenko@'s comment Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabDelegateFactory.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabDelegateFactory.java b/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabDelegateFactory.java

index 0ab18c167f885cf46afe81cb6b7d8ddff219584f..690cc6c80ebd13f47793b4166dfe400f85d1a1b3 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabDelegateFactory.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabDelegateFactory.java

@@ -54,7 +54,7 @@ public class CustomTabDelegateFactory extends TabDelegateFactory {

@Override

public boolean startActivityIfNeeded(Intent intent) {

- boolean isExternalProtocol = !UrlUtilities.isAcceptedScheme(intent.getDataString());

+ boolean isExternalProtocol = !UrlUtilities.isAcceptedScheme(intent.toUri(0));

boolean hasDefaultHandler = hasDefaultHandler(intent);

try {

// For a URL chrome can handle and there is no default set, handle it ourselves.

« no previous file with comments | « no previous file | no next file » | no next file with comments »