Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 2147543002: Revert of PrecacheFetcher::CancelPrecaching should run in the main UI thread (Closed)

Created:
4 years, 5 months ago by picksi1
Modified:
4 years, 5 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, wifiprefetch-reviews_google.com
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of PrecacheFetcher::CancelPrecaching should run in the main UI thread (patchset #4 id:60001 of https://codereview.chromium.org/2137593002/ ) Reason for revert: Android Test (dbg) has turned red, with failures: C 860.211s Main [ FAILED ] org.chromium.chrome.browser.precache.PrecacheControllerTest#testDeviceStateChangeCancels C 860.211s Main [ FAILED ] org.chromium.chrome.browser.precache.PrecacheControllerTest#testTimeoutCancelsPrecaching C 860.211s Main [ FAILED ] org.chromium.chrome.browser.precache.PrecacheControllerTest#testTimeoutDoesNotCancelIfNotPrecaching (UNKNOWN) C 860.211s Main [ FAILED ] org.chromium.chrome.browser.precache.PrecacheLauncherTest#testUpdateEnabled_Disabled_ThenEnabled (UNKNOWN) C 860.211s Main [ FAILED ] org.chromium.chrome.browser.precache.PrecacheLauncherTest#testUpdateEnabled_SyncNotReady_ThenEnabled (UNKNOWN) Link to bot: https://uberchromegw.corp.google.com/i/chromium.linux/builders/Android%20Tests%20(dbg) Original issue's description: > PrecacheFetcher::CancelPrecaching should run in the main UI thread > > Reducing the possibilities of crash in CancelPrecaching. > > BUG=619111 > > Committed: https://crrev.com/28e7a0cc33dafc8719c4b9c740d79a47ff90f067 > Cr-Commit-Position: refs/heads/master@{#404792} TBR=sclittle@chromium.org,rajendrant@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=619111 Committed: https://crrev.com/285187208715fc68c217d4a7d237f96277fce50c Cr-Commit-Position: refs/heads/master@{#404810}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -28 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/precache/PrecacheController.java View 2 chunks +7 lines, -15 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/precache/PrecacheControllerTest.java View 3 chunks +0 lines, -3 lines 0 comments Download
M components/precache/content/precache_manager.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M components/precache/core/precache_fetcher.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
picksi1
Created Revert of PrecacheFetcher::CancelPrecaching should run in the main UI thread
4 years, 5 months ago (2016-07-12 14:25:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2147543002/1
4 years, 5 months ago (2016-07-12 14:26:23 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 5 months ago (2016-07-12 14:26:25 UTC) #5
alex clarke (OOO till 29th)
lgtm
4 years, 5 months ago (2016-07-12 14:28:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2147543002/1
4 years, 5 months ago (2016-07-12 14:33:49 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-12 14:34:41 UTC) #11
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-12 14:34:51 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-12 14:36:30 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/285187208715fc68c217d4a7d237f96277fce50c
Cr-Commit-Position: refs/heads/master@{#404810}

Powered by Google App Engine
This is Rietveld 408576698