Chromium Code Reviews
DescriptionRevert of PrecacheFetcher::CancelPrecaching should run in the main UI thread (patchset #4 id:60001 of https://codereview.chromium.org/2137593002/ )
Reason for revert:
Android Test (dbg) has turned red, with failures:
C 860.211s Main [ FAILED ] org.chromium.chrome.browser.precache.PrecacheControllerTest#testDeviceStateChangeCancels
C 860.211s Main [ FAILED ] org.chromium.chrome.browser.precache.PrecacheControllerTest#testTimeoutCancelsPrecaching
C 860.211s Main [ FAILED ] org.chromium.chrome.browser.precache.PrecacheControllerTest#testTimeoutDoesNotCancelIfNotPrecaching (UNKNOWN)
C 860.211s Main [ FAILED ] org.chromium.chrome.browser.precache.PrecacheLauncherTest#testUpdateEnabled_Disabled_ThenEnabled (UNKNOWN)
C 860.211s Main [ FAILED ] org.chromium.chrome.browser.precache.PrecacheLauncherTest#testUpdateEnabled_SyncNotReady_ThenEnabled (UNKNOWN)
Link to bot:
https://uberchromegw.corp.google.com/i/chromium.linux/builders/Android%20Tests%20(dbg)
Original issue's description:
> PrecacheFetcher::CancelPrecaching should run in the main UI thread
>
> Reducing the possibilities of crash in CancelPrecaching.
>
> BUG=619111
>
> Committed: https://crrev.com/28e7a0cc33dafc8719c4b9c740d79a47ff90f067
> Cr-Commit-Position: refs/heads/master@{#404792}
TBR=sclittle@chromium.org,rajendrant@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=619111
Committed: https://crrev.com/285187208715fc68c217d4a7d237f96277fce50c
Cr-Commit-Position: refs/heads/master@{#404810}
Patch Set 1 #
Messages
Total messages: 14 (6 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||