SkRasterPipeline preliminaries

SkRasterPipeline preliminaries

Windows trybots appear to be failing because the CL number is > 2^31.  :/

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2147533002
CQ_INCLUDE_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot

[mtklein_C, 2016-07-12 14:21:41]

Description was changed from

==========
SkRasterStage preliminaries

BUG=skia:
==========

to

==========
SkRasterStage preliminaries

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2147533002
==========

[mtklein_C, 2016-07-12 15:28:16]

The CQ bit was checked by mtklein@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-12 15:28:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-12 15:31:53]

The CQ bit was unchecked by commit-bot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-12 15:31:54]

Dry run: Try jobs failed on following builders:
  Build-Ubuntu-GCC-Mips-Debug-Android-Trybot on master.client.skia.compile
(JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Mip...)

[mtklein_C, 2016-07-12 15:54:51]

Description was changed from

==========
SkRasterStage preliminaries

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2147533002
==========

to

==========
SkRasterPipeline preliminaries

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2147533002
==========

[mtklein_C, 2016-07-12 15:56:21]

The CQ bit was checked by mtklein@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-12 15:56:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-12 16:01:14]

The CQ bit was unchecked by commit-bot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-12 16:01:16]

Dry run: Try jobs failed on following builders:
  Build-Win-MSVC-x86_64-Debug-Trybot on master.client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_6...)

[mtklein_C, 2016-07-12 16:45:11]

The CQ bit was checked by mtklein@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-12 16:45:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-12 16:50:11]

The CQ bit was unchecked by commit-bot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-12 16:50:12]

Dry run: Try jobs failed on following builders:
  Build-Win-MSVC-x86_64-Debug-Trybot on master.client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_6...)

[mtklein_C, 2016-07-12 16:51:24]

Description was changed from

==========
SkRasterPipeline preliminaries

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2147533002
==========

to

==========
SkRasterPipeline preliminaries

Windows trybots appear to be failing because the CL number is > 2^31.  :/

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2147533002
==========

[mtklein_C, 2016-07-12 16:52:15]

mtklein@chromium.org changed reviewers:
+ herb@google.com

[mtklein_C, 2016-07-12 16:52:16]

This ports over the core of things into the Skia codebase, with a test and a
bench.

[mtklein_C, 2016-07-12 17:02:54]

Description was changed from

==========
SkRasterPipeline preliminaries

Windows trybots appear to be failing because the CL number is > 2^31.  :/

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2147533002
==========

to

==========
SkRasterPipeline preliminaries

Windows trybots appear to be failing because the CL number is > 2^31.  :/

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2147533002
CQ_INCLUDE_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
==========

[mtklein_C, 2016-07-12 17:03:09]

The CQ bit was checked by mtklein@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-12 17:03:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-12 17:09:29]

The CQ bit was unchecked by commit-bot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-12 17:09:30]

Dry run: Try jobs failed on following builders:
  Build-Win-MSVC-x86-Debug-Trybot on master.client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-D...)

[reed1, 2016-07-12 17:36:33]

reed@google.com changed reviewers:
+ reed@google.com

[reed1, 2016-07-12 17:36:34]

I quiver with antici...

[herb_g, 2016-07-12 18:14:25]

lgtm

https://codereview.chromium.org/2147533002/diff/160001/src/core/SkRasterPipel...
File src/core/SkRasterPipeline.cpp (right):

https://codereview.chromium.org/2147533002/diff/160001/src/core/SkRasterPipel...
src/core/SkRasterPipeline.cpp:16: fBody.push_back({ body,
const_cast<void*>(body_ctx) });
SkASSERT(!fReadyToRun)

https://codereview.chromium.org/2147533002/diff/160001/src/core/SkRasterPipel...
src/core/SkRasterPipeline.cpp:21: SkASSERT(!stages->empty());
RedayToRun assert here too

[mtklein_C, 2016-07-12 18:24:08]

The CQ bit was checked by mtklein@chromium.org to run a CQ dry run

[mtklein_C, 2016-07-12 18:24:16]

https://codereview.chromium.org/2147533002/diff/160001/src/core/SkRasterPipel...
File src/core/SkRasterPipeline.cpp (right):

https://codereview.chromium.org/2147533002/diff/160001/src/core/SkRasterPipel...
src/core/SkRasterPipeline.cpp:16: fBody.push_back({ body,
const_cast<void*>(body_ctx) });
On 2016/07/12 at 18:14:25, herb_g wrote:
> SkASSERT(!fReadyToRun)

Done.

https://codereview.chromium.org/2147533002/diff/160001/src/core/SkRasterPipel...
src/core/SkRasterPipeline.cpp:21: SkASSERT(!stages->empty());
On 2016/07/12 at 18:14:25, herb_g wrote:
> RedayToRun assert here too

Done, by inlining Rewire() into run() as a lambda.

[commit-bot: I haz the power, 2016-07-12 18:24:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mtklein, 2016-07-12 18:30:19]

The CQ bit was checked by mtklein@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-12 18:30:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-12 18:39:43]

The CQ bit was unchecked by commit-bot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-12 18:39:44]

Dry run: Try jobs failed on following builders:
  Build-Win-MSVC-x86_64-Debug-Trybot on master.client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_6...)

[mtklein_C, 2016-07-12 18:45:17]

The CQ bit was checked by mtklein@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-12 18:45:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-12 18:50:49]

The CQ bit was unchecked by commit-bot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-12 18:50:50]

Dry run: Try jobs failed on following builders:
  Build-Win-MSVC-x86-Debug-Trybot on master.client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-D...)