Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 214753004: Mojo: Move mojo/public/system/core_cpp.h to mojo/cpp/public/system/core.h. (Closed)

Created:
6 years, 9 months ago by viettrungluu
Modified:
6 years, 9 months ago
CC:
chromium-reviews, viettrungluu+watch_chromium.org, jam, abarth-chromium, joi+watch-content_chromium.org, Aaron Boodman, darin-cc_chromium.org, darin (slow to review), ben+mojo_chromium.org
Visibility:
Public.

Description

Mojo: Move mojo/public/system/core_cpp.h to mojo/cpp/public/system/core.h. Also begin rearranging tests. (I'm deferring moving macros_unittest.cc until after I split macros.h.) R=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260048

Patch Set 1 #

Patch Set 2 : rebased/updated #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -1609 lines) Patch
M content/browser/renderer_host/render_process_host_impl.h View 1 1 chunk +1 line, -1 line 0 comments Download
M content/common/mojo/mojo_channel_init.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/public/browser/render_view_host.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/web_ui_mojo.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/web_ui_mojo_context_state.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/apps/js/bindings/monotonic_clock.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/apps/js/main.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/bindings/js/handle.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/bindings/js/support.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/common/handle_watcher.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/common/handle_watcher_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/common/message_pump_mojo.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/common/message_pump_mojo_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/embedder/embedder.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/examples/compositor_app/compositor_host.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/examples/compositor_app/mojo_context_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/examples/pepper_container_app/mojo_ppapi_globals.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/gles2/gles2_context.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/mojo_public.gypi View 1 4 chunks +6 lines, -5 lines 0 comments Download
M mojo/public/bindings/interface.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/bindings/lib/array_internal.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/bindings/lib/bindings_internal.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/bindings/lib/connector.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/bindings/passable.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/bindings/sync_dispatcher.h View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/public/c/tests/DEPS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/c/tests/system/core_perftest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/c/tests/system/core_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/c/tests/system/core_unittest_pure_c.c View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/cpp/system/core.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + mojo/public/cpp/tests/DEPS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/cpp/tests/system/core_unittest.cc View 1 chunk +5 lines, -1 line 0 comments Download
M mojo/public/environment/tests/async_waiter_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/gles2/gles2_private.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/shell/application.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/shell/service.h View 1 chunk +1 line, -1 line 0 comments Download
D mojo/public/system/core_cpp.h View 1 chunk +0 lines, -467 lines 0 comments Download
D mojo/public/tests/system/core_cpp_unittest.cc View 1 chunk +0 lines, -388 lines 0 comments Download
D mojo/public/tests/system/core_perftest.cc View 1 chunk +0 lines, -337 lines 0 comments Download
D mojo/public/tests/system/core_unittest.cc View 1 chunk +0 lines, -286 lines 0 comments Download
D mojo/public/tests/system/core_unittest_pure_c.c View 1 chunk +0 lines, -88 lines 0 comments Download
M mojo/public/tests/test_utils.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/tests/test_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/utility/run_loop.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/utility/run_loop_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/utility/tests/run_loop_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/gles2/command_buffer_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/app_child_process.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/app_child_process_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/dynamic_service_loader.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
viettrungluu
6 years, 9 months ago (2014-03-27 16:51:59 UTC) #1
darin (slow to review)
LGTM (I fixed up the CL description.)
6 years, 9 months ago (2014-03-27 19:27:23 UTC) #2
viettrungluu
The CQ bit was checked by viettrungluu@chromium.org
6 years, 9 months ago (2014-03-27 19:44:41 UTC) #3
viettrungluu
The CQ bit was unchecked by viettrungluu@chromium.org
6 years, 9 months ago (2014-03-27 19:45:08 UTC) #4
viettrungluu
The CQ bit was checked by viettrungluu@chromium.org
6 years, 9 months ago (2014-03-27 20:56:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/214753004/20001
6 years, 9 months ago (2014-03-27 21:05:28 UTC) #6
viettrungluu
6 years, 9 months ago (2014-03-28 00:53:37 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 manually as r260048 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698