Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2147493007: Fix documentation for Measure and MeasureAs IDL extended attributes. (Closed)

Created:
4 years, 5 months ago by Marijn Kruisselbrink
Modified:
4 years, 5 months ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-bindings_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix documentation for Measure and MeasureAs IDL extended attributes. The Measure and MeasureAs extended attributes were incorrectly listed as not being allowed in interfaces. These attributes are in fact allowed on interfaces, and measure usage of the constructor of the interface. Committed: https://crrev.com/de1accf3ced48ab7578c8f3329821be23ecae938 Cr-Commit-Position: refs/heads/master@{#405647}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M third_party/WebKit/Source/bindings/IDLExtendedAttributes.md View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
Marijn Kruisselbrink
4 years, 5 months ago (2016-07-14 19:13:58 UTC) #3
haraken
LGTM
4 years, 5 months ago (2016-07-15 00:02:59 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2147493007/1
4 years, 5 months ago (2016-07-15 00:35:25 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-15 00:42:21 UTC) #11
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-15 00:42:32 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-15 00:43:43 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/de1accf3ced48ab7578c8f3329821be23ecae938
Cr-Commit-Position: refs/heads/master@{#405647}

Powered by Google App Engine
This is Rietveld 408576698