Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2147493005: Remove per-isolate compile-time constants cache. (Closed)

Created:
4 years, 5 months ago by rmacnak
Modified:
4 years, 5 months ago
Reviewers:
turnidge, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove per-isolate compile-time constants cache. There are no scripts in the VM isolate as of 83da4db9f9f5d8d5894e603c9a10402f328f0aac. R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/ee942bd8d615eee073fea08031a24aedf51a722f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -140 lines) Patch
M runtime/vm/object_store.h View 3 chunks +1 line, -9 lines 0 comments Download
M runtime/vm/object_store.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/parser.h View 1 chunk +4 lines, -75 lines 0 comments Download
M runtime/vm/parser.cc View 2 chunks +18 lines, -54 lines 0 comments Download
M runtime/vm/precompiler.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
rmacnak
4 years, 5 months ago (2016-07-13 00:01:41 UTC) #2
siva
lgtm
4 years, 5 months ago (2016-07-13 00:08:17 UTC) #3
rmacnak
4 years, 5 months ago (2016-07-13 00:36:03 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ee942bd8d615eee073fea08031a24aedf51a722f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698