Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(686)

Issue 2147493004: Add a function to convert a texture backed SkImage to raster. (Closed)

Created:
4 years, 5 months ago by bsalomon
Modified:
4 years, 5 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add a function to convert a texture backed SkImage to raster. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2147493004 Committed: https://skia.googlesource.com/skia/+/634b43008025d039f3f2f1f6c01e8044ffbb901f

Patch Set 1 #

Patch Set 2 : cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -0 lines) Patch
M include/core/SkImage.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M src/image/SkImage.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M src/image/SkImage_Gpu.cpp View 1 1 chunk +25 lines, -0 lines 0 comments Download
M tests/ImageTest.cpp View 1 chunk +27 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
bsalomon
I want to use this here: https://cs.chromium.org/chromium/src/media/renderers/skcanvas_video_renderer.cc?sq=package:chromium&l=441 to eliminate the last public use case of ...
4 years, 5 months ago (2016-07-12 21:27:37 UTC) #3
reed1
lgtm
4 years, 5 months ago (2016-07-12 22:44:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2147493004/20001
4 years, 5 months ago (2016-07-13 01:10:23 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 01:11:21 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/634b43008025d039f3f2f1f6c01e8044ffbb901f

Powered by Google App Engine
This is Rietveld 408576698