Cleanup: remove dead code from InstantPage and InstantController

Cleanup: remove dead code from InstantPage and InstantController

BUG=627747
Committed: https://crrev.com/63441181c608f63317bba47e788e173e161e1687
Cr-Commit-Position: refs/heads/master@{#405106}

[Marc Treib, 2016-07-12 13:36:14]

The CQ bit was checked by treib@chromium.org to run a CQ dry run

[Marc Treib, 2016-07-12 13:36:24]

treib@chromium.org changed reviewers:
+ sfiera@chromium.org

[commit-bot: I haz the power, 2016-07-12 13:36:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sfiera, 2016-07-12 13:41:40]

LGTM

https://codereview.chromium.org/2147483002/diff/1/chrome/browser/ui/search/in...
File chrome/browser/ui/search/instant_page.h (right):

https://codereview.chromium.org/2147483002/diff/1/chrome/browser/ui/search/in...
chrome/browser/ui/search/instant_page.h:24: // InstantPage is not used directly
but via its derived class, InstantTab.
Should I just delete InstantTab then in
https://codereview.chromium.org/2141933002/diff/60001/chrome/browser/ui/searc...
There's almost nothing left of it.

[Marc Treib, 2016-07-12 13:46:16]

https://codereview.chromium.org/2147483002/diff/1/chrome/browser/ui/search/in...
File chrome/browser/ui/search/instant_page.h (right):

https://codereview.chromium.org/2147483002/diff/1/chrome/browser/ui/search/in...
chrome/browser/ui/search/instant_page.h:24: // InstantPage is not used directly
but via its derived class, InstantTab.
On 2016/07/12 13:41:40, sfiera wrote:
> Should I just delete InstantTab then in
>
https://codereview.chromium.org/2141933002/diff/60001/chrome/browser/ui/searc...
> There's almost nothing left of it.

I guess InstantPage should be merged into it? I'd keep that for another CL
though.

[Marc Treib, 2016-07-12 13:47:09]

treib@chromium.org changed reviewers:
+ markusheintz@chromium.org

[Marc Treib, 2016-07-12 13:47:09]

+markusheintz - can I get a quick committer's approval please? Chris already
reviewed this.

[commit-bot: I haz the power, 2016-07-12 15:40:34]

The CQ bit was unchecked by commit-bot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-12 15:40:35]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[markusheintz_, 2016-07-13 08:21:17]

On 2016/07/12 13:47:09, Marc Treib wrote:
> +markusheintz - can I get a quick committer's approval please? Chris already
> reviewed this.

LGTM

[Marc Treib, 2016-07-13 08:57:25]

Description was changed from

==========
Cleanup: remove dead code from InstantPage and InstantController

BUG=none
==========

to

==========
Cleanup: remove dead code from InstantPage and InstantController

BUG=627747
==========

[Marc Treib, 2016-07-13 08:57:57]

The CQ bit was checked by treib@chromium.org

[commit-bot: I haz the power, 2016-07-13 08:58:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 09:29:55]

Description was changed from

==========
Cleanup: remove dead code from InstantPage and InstantController

BUG=627747
==========

to

==========
Cleanup: remove dead code from InstantPage and InstantController

BUG=627747
==========

[commit-bot: I haz the power, 2016-07-13 09:29:57]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-13 09:31:58]

Description was changed from

==========
Cleanup: remove dead code from InstantPage and InstantController

BUG=627747
==========

to

==========
Cleanup: remove dead code from InstantPage and InstantController

BUG=627747

Committed: https://crrev.com/63441181c608f63317bba47e788e173e161e1687
Cr-Commit-Position: refs/heads/master@{#405106}
==========

[commit-bot: I haz the power, 2016-07-13 09:32:00]

Patchset 1 (id:??) landed as
https://crrev.com/63441181c608f63317bba47e788e173e161e1687
Cr-Commit-Position: refs/heads/master@{#405106}