Set 'ResourceRequest::requestorOrigin' in Blink for more request types.

Set 'ResourceRequest::requestorOrigin' in Blink for more request types.

This patch ensures that we set the correct request initiator for all
requests that run through Blink's ResourceFetcher (which is basically
everything except navigation) by extending
'FrameFetchContext::setFirstPartyForCookies' into a more general-purpose
setter that also takes care of 'requestorOrigin', applying these setting
to requests sent through 'PingLoader' and 'BeaconLoader'. This doesn't have any
web-visible effect, but it will allow us to remove the requestor origin
setting from 'content::RenderFrameImpl' in the somewhat near future.

As a drive-by, this fixes 'FrameFetchContext::setFirstPartyForCookies's
current implementation, which was providing the wrong first-party for
nested and cross-origin requests sent through 'PingLoader' and 'BeaconLoader'.

BUG=625969
R=jochen@chromium.org

Committed: https://crrev.com/47673cd03085ab0879683e2a782a4eb3a4eecb4b
Cr-Commit-Position: refs/heads/master@{#405459}

[Mike West, 2016-07-12 13:16:43]

Patchset #1 (id:1) has been deleted

[Mike West, 2016-07-12 13:22:57]

Patchset #1 (id:20001) has been deleted

[Mike West, 2016-07-12 13:23:43]

Jochen, have a few minutes to look at this? The bulk of the patch's actual work
is in FrameFetchContext. The //content changes are all new tests, as is most of
the //third_party/WebKit change....

[jochen (gone - plz use gerrit), 2016-07-13 07:46:59]

can you merge setFirstPartyForCookies into populateRequestData?

[Mike West, 2016-07-13 10:12:03]

On 2016/07/13 at 07:46:59, jochen wrote:
> can you merge setFirstPartyForCookies into populateRequestData?

Sure. Makes sense to me... Done in latest patchset.

[Mike West, 2016-07-13 10:25:47]

Description was changed from

==========
Set 'ResourceRequest::requestorOrigin' in Blink for more request types.

This patch ensures that we set the correct request initiator for all
requests that run through Blink's ResourceFetcher (which is basically
everything except navigation), and applies the same setting to requests
sent through 'PingLoader' and 'BeaconLoader'. This doesn't have any
web-visible effect, but it will allow us to remove the requestor origin
setting from 'content::RenderFrameImpl' in the somewhat near future.

As a drive-by, this fixes 'FrameFetchContext::setFirstPartyForCookies',
which was providing the wrong first-party for nested and cross-origin
requests sent through 'PingLoader' and 'BeaconLoader'.

BUG=625969
R=jochen@chromium.org
==========

to

==========
Set 'ResourceRequest::requestorOrigin' in Blink for more request types.

This patch ensures that we set the correct request initiator for all
requests that run through Blink's ResourceFetcher (which is basically
everything except navigation) by extending
'FrameFetchContext::setFirstPartyForCookies' into a more general-purpose
setter that also takes care of 'requestorOrigin', applying these setting
to requests sent through 'PingLoader' and 'BeaconLoader'. This doesn't have any
web-visible effect, but it will allow us to remove the requestor origin
setting from 'content::RenderFrameImpl' in the somewhat near future.

As a drive-by, this fixes 'FrameFetchContext::setFirstPartyForCookies's
current implementation, which was providing the wrong first-party for
nested and cross-origin requests sent through 'PingLoader' and 'BeaconLoader'.

BUG=625969
R=jochen@chromium.org
==========

[jochen (gone - plz use gerrit), 2016-07-13 12:42:45]

lgtm

[Mike West, 2016-07-14 07:48:49]

The CQ bit was checked by mkwst@chromium.org

[commit-bot: I haz the power, 2016-07-14 07:49:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-14 08:53:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-14 08:53:21]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Mike West, 2016-07-14 09:21:33]

The CQ bit was checked by mkwst@chromium.org

[commit-bot: I haz the power, 2016-07-14 09:22:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-14 09:49:16]

Committed patchset #2 (id:60001)

[commit-bot: I haz the power, 2016-07-14 09:49:18]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-14 09:51:01]

Description was changed from

==========
Set 'ResourceRequest::requestorOrigin' in Blink for more request types.

This patch ensures that we set the correct request initiator for all
requests that run through Blink's ResourceFetcher (which is basically
everything except navigation) by extending
'FrameFetchContext::setFirstPartyForCookies' into a more general-purpose
setter that also takes care of 'requestorOrigin', applying these setting
to requests sent through 'PingLoader' and 'BeaconLoader'. This doesn't have any
web-visible effect, but it will allow us to remove the requestor origin
setting from 'content::RenderFrameImpl' in the somewhat near future.

As a drive-by, this fixes 'FrameFetchContext::setFirstPartyForCookies's
current implementation, which was providing the wrong first-party for
nested and cross-origin requests sent through 'PingLoader' and 'BeaconLoader'.

BUG=625969
R=jochen@chromium.org
==========

to

==========
Set 'ResourceRequest::requestorOrigin' in Blink for more request types.

This patch ensures that we set the correct request initiator for all
requests that run through Blink's ResourceFetcher (which is basically
everything except navigation) by extending
'FrameFetchContext::setFirstPartyForCookies' into a more general-purpose
setter that also takes care of 'requestorOrigin', applying these setting
to requests sent through 'PingLoader' and 'BeaconLoader'. This doesn't have any
web-visible effect, but it will allow us to remove the requestor origin
setting from 'content::RenderFrameImpl' in the somewhat near future.

As a drive-by, this fixes 'FrameFetchContext::setFirstPartyForCookies's
current implementation, which was providing the wrong first-party for
nested and cross-origin requests sent through 'PingLoader' and 'BeaconLoader'.

BUG=625969
R=jochen@chromium.org

Committed: https://crrev.com/47673cd03085ab0879683e2a782a4eb3a4eecb4b
Cr-Commit-Position: refs/heads/master@{#405459}
==========

[commit-bot: I haz the power, 2016-07-14 09:51:02]

Patchset 2 (id:??) landed as
https://crrev.com/47673cd03085ab0879683e2a782a4eb3a4eecb4b
Cr-Commit-Position: refs/heads/master@{#405459}