Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 2147443005: arc: Use FOR_EACH_OBSERVER in InstanceHolder (Closed)

Created:
4 years, 5 months ago by Luis Héctor Chávez
Modified:
4 years, 5 months ago
Reviewers:
hidehiko
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, yusukes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/a/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

arc: Use FOR_EACH_OBSERVER in InstanceHolder Now that FOR_EACH_OBSERVER supports dependent types, we can use it instead of its expansion. BUG=627209 TEST=trybots Committed: https://crrev.com/05b7d4f124a608289ff685341c146cb7e38f1fd6 Cr-Commit-Position: refs/heads/master@{#405174}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -12 lines) Patch
M components/arc/instance_holder.h View 2 chunks +2 lines, -12 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Luis Héctor Chávez
PTAL
4 years, 5 months ago (2016-07-13 14:58:39 UTC) #4
hidehiko
lgtm
4 years, 5 months ago (2016-07-13 16:04:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2147443005/1
4 years, 5 months ago (2016-07-13 16:07:59 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-13 16:14:53 UTC) #10
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-13 16:15:08 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 16:16:25 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/05b7d4f124a608289ff685341c146cb7e38f1fd6
Cr-Commit-Position: refs/heads/master@{#405174}

Powered by Google App Engine
This is Rietveld 408576698