src/ic/ic.cc - Issue 2147433002: [ic] [stubs] Don't use Code::flags in megamorphic stub cache hash computations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ic/ic.cc

Issue 2147433002: [ic] [stubs] Don't use Code::flags in megamorphic stub cache hash computations. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@split-stub-cache

Patch Set: Improved stub cache tests and the fixes. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ic/ic.cc

diff --git a/src/ic/ic.cc b/src/ic/ic.cc

index 43f50a4117845778ee54cd70111d74965b34404b..fe474cdf956f27c4685e28bb90f241ba2c6b8f6f 100644

--- a/src/ic/ic.cc

+++ b/src/ic/ic.cc

@@ -1043,8 +1043,7 @@ Handle<Object> IC::ComputeHandler(LookupIterator* lookup,

// cache (which just missed) is different from the cached handler.

if (state() == MEGAMORPHIC && lookup->GetReceiver()->IsHeapObject()) {

Map* map = Handle<HeapObject>::cast(lookup->GetReceiver())->map();

- Code* megamorphic_cached_code =

- stub_cache()->Get(*lookup->name(), map, code->flags());

+ Code* megamorphic_cached_code = stub_cache()->Get(*lookup->name(), map);

if (megamorphic_cached_code != *code) {

TRACE_HANDLER_STATS(isolate(), IC_HandlerCacheHit);

return code;

« no previous file with comments | « src/ic/ia32/stub-cache-ia32.cc ('k') | src/ic/mips/stub-cache-mips.cc » ('j') | no next file with comments »