Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Side by Side Diff: src/code-stub-assembler.h

Issue 2147433002: [ic] [stubs] Don't use Code::flags in megamorphic stub cache hash computations. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@split-stub-cache
Patch Set: Improved stub cache tests and the fixes. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/arm64/macro-assembler-arm64.cc ('k') | src/code-stub-assembler.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 the V8 project authors. All rights reserved. 1 // Copyright 2016 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_CODE_STUB_ASSEMBLER_H_ 5 #ifndef V8_CODE_STUB_ASSEMBLER_H_
6 #define V8_CODE_STUB_ASSEMBLER_H_ 6 #define V8_CODE_STUB_ASSEMBLER_H_
7 7
8 #include <functional> 8 #include <functional>
9 9
10 #include "src/compiler/code-assembler.h" 10 #include "src/compiler/code-assembler.h"
(...skipping 432 matching lines...) Expand 10 before | Expand all | Expand 10 after
443 compiler::Node* receiver_map, 443 compiler::Node* receiver_map,
444 Label* if_handler, Variable* var_handler, 444 Label* if_handler, Variable* var_handler,
445 Label* if_miss); 445 Label* if_miss);
446 void HandlePolymorphicCase(const LoadICParameters* p, 446 void HandlePolymorphicCase(const LoadICParameters* p,
447 compiler::Node* receiver_map, 447 compiler::Node* receiver_map,
448 compiler::Node* feedback, Label* if_handler, 448 compiler::Node* feedback, Label* if_handler,
449 Variable* var_handler, Label* if_miss, 449 Variable* var_handler, Label* if_miss,
450 int unroll_count); 450 int unroll_count);
451 451
452 compiler::Node* StubCachePrimaryOffset(compiler::Node* name, 452 compiler::Node* StubCachePrimaryOffset(compiler::Node* name,
453 Code::Flags flags,
454 compiler::Node* map); 453 compiler::Node* map);
455 454
456 compiler::Node* StubCacheSecondaryOffset(compiler::Node* name, 455 compiler::Node* StubCacheSecondaryOffset(compiler::Node* name,
457 Code::Flags flags,
458 compiler::Node* seed); 456 compiler::Node* seed);
459 457
460 // This enum is used here as a replacement for StubCache::Table to avoid 458 // This enum is used here as a replacement for StubCache::Table to avoid
461 // including stub cache header. 459 // including stub cache header.
462 enum StubCacheTable : int; 460 enum StubCacheTable : int;
463 461
464 void TryProbeStubCacheTable(StubCache* stub_cache, StubCacheTable table_id, 462 void TryProbeStubCacheTable(StubCache* stub_cache, StubCacheTable table_id,
465 compiler::Node* entry_offset, 463 compiler::Node* entry_offset,
466 compiler::Node* name, Code::Flags flags, 464 compiler::Node* name, compiler::Node* map,
467 compiler::Node* map, Label* if_handler, 465 Label* if_handler, Variable* var_handler,
468 Variable* var_handler, Label* if_miss); 466 Label* if_miss);
469 467
470 void TryProbeStubCache(StubCache* stub_cache, compiler::Node* receiver, 468 void TryProbeStubCache(StubCache* stub_cache, compiler::Node* receiver,
471 compiler::Node* name, Label* if_handler, 469 compiler::Node* name, Label* if_handler,
472 Variable* var_handler, Label* if_miss); 470 Variable* var_handler, Label* if_miss);
473 471
474 void LoadIC(const LoadICParameters* p); 472 void LoadIC(const LoadICParameters* p);
475 void LoadGlobalIC(const LoadICParameters* p); 473 void LoadGlobalIC(const LoadICParameters* p);
476 474
477 private: 475 private:
478 compiler::Node* ElementOffsetFromIndex(compiler::Node* index, 476 compiler::Node* ElementOffsetFromIndex(compiler::Node* index,
479 ElementsKind kind, ParameterMode mode, 477 ElementsKind kind, ParameterMode mode,
480 int base_size = 0); 478 int base_size = 0);
481 479
482 compiler::Node* AllocateRawAligned(compiler::Node* size_in_bytes, 480 compiler::Node* AllocateRawAligned(compiler::Node* size_in_bytes,
483 AllocationFlags flags, 481 AllocationFlags flags,
484 compiler::Node* top_address, 482 compiler::Node* top_address,
485 compiler::Node* limit_address); 483 compiler::Node* limit_address);
486 compiler::Node* AllocateRawUnaligned(compiler::Node* size_in_bytes, 484 compiler::Node* AllocateRawUnaligned(compiler::Node* size_in_bytes,
487 AllocationFlags flags, 485 AllocationFlags flags,
488 compiler::Node* top_adddress, 486 compiler::Node* top_adddress,
489 compiler::Node* limit_address); 487 compiler::Node* limit_address);
490 488
491 static const int kElementLoopUnrollThreshold = 8; 489 static const int kElementLoopUnrollThreshold = 8;
492 }; 490 };
493 491
494 } // namespace internal 492 } // namespace internal
495 } // namespace v8 493 } // namespace v8
496 #endif // V8_CODE_STUB_ASSEMBLER_H_ 494 #endif // V8_CODE_STUB_ASSEMBLER_H_
OLDNEW
« no previous file with comments | « src/arm64/macro-assembler-arm64.cc ('k') | src/code-stub-assembler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698