Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 2147403002: V8. ASM-2-WASM. Fixes issue 628446. (Closed)

Created:
4 years, 5 months ago by John
Modified:
4 years, 5 months ago
Reviewers:
mmohammad, bradnelson
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

V8. ASM-2-WASM. Fixes issue 628446. The issue was caused by a mishandling of "special" identifiers, i.e., the module's name, and the module's parameter. BUG= https://bugs.chromium.org/p/chromium/issues/detail?id=628446 BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203 TEST= cctest/asmjs/test-asm-typer.cc TEST= cctest/wasm/* LOG=N Committed: https://crrev.com/a25e9c6f970fdcead8faffd1b7cc64b6d1f78a49 Cr-Commit-Position: refs/heads/master@{#37800}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -29 lines) Patch
M src/asmjs/asm-typer.h View 4 chunks +6 lines, -3 lines 0 comments Download
M src/asmjs/asm-typer.cc View 9 chunks +22 lines, -17 lines 0 comments Download
M test/cctest/asmjs/test-asm-typer.cc View 5 chunks +42 lines, -9 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
John
4 years, 5 months ago (2016-07-15 02:11:21 UTC) #4
John
4 years, 5 months ago (2016-07-15 14:44:14 UTC) #7
bradnelson
lgtm
4 years, 5 months ago (2016-07-15 16:07:43 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2147403002/1
4 years, 5 months ago (2016-07-15 16:07:47 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-15 16:09:50 UTC) #11
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-15 16:09:52 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-15 16:10:31 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a25e9c6f970fdcead8faffd1b7cc64b6d1f78a49
Cr-Commit-Position: refs/heads/master@{#37800}

Powered by Google App Engine
This is Rietveld 408576698