Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 2147363002: More guarding of code under #ifndef PRODUCT ... #endif (Closed)

Created:
4 years, 5 months ago by siva
Modified:
4 years, 5 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

More guarding of code under #ifndef PRODUCT ... #endif R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/e0164a0ceb926c28a7541f9d78cc94c202aca84b

Patch Set 1 #

Patch Set 2 : Fix inadvertant change. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M runtime/vm/flow_graph_range_analysis.cc View 4 chunks +8 lines, -0 lines 0 comments Download
M runtime/vm/isolate.cc View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
siva
4 years, 5 months ago (2016-07-15 00:17:58 UTC) #2
rmacnak
lgtm
4 years, 5 months ago (2016-07-15 00:25:11 UTC) #3
siva
4 years, 5 months ago (2016-07-15 00:44:28 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
e0164a0ceb926c28a7541f9d78cc94c202aca84b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698