Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(528)

Unified Diff: third_party/WebKit/Source/core/html/HTMLElement.cpp

Issue 2147353002: Merge "Placeholder content direction should not affect INPUT/TEXTAREA direction." to M52 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2743
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/forms/textarea/textarea-dir-auto-with-placeholder.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/html/HTMLElement.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLElement.cpp b/third_party/WebKit/Source/core/html/HTMLElement.cpp
index 6c0a92df0a19f5eb2ce43ca4718d0dd0755d202e..10f05214d6b8900dbda57c630cfaae85a3daab18 100644
--- a/third_party/WebKit/Source/core/html/HTMLElement.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLElement.cpp
@@ -736,7 +736,8 @@ TextDirection HTMLElement::directionality(Node** strongDirectionalityTextNode) c
while (node) {
// Skip bdi, script, style and text form controls.
if (equalIgnoringCase(node->nodeName(), "bdi") || isHTMLScriptElement(*node) || isHTMLStyleElement(*node)
- || (node->isElementNode() && toElement(node)->isTextFormControl())) {
+ || (node->isElementNode() && toElement(node)->isTextFormControl())
+ || (node->isElementNode() && toElement(node)->shadowPseudoId() == "-webkit-input-placeholder")) {
node = FlatTreeTraversal::nextSkippingChildren(*node, this);
continue;
}
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/forms/textarea/textarea-dir-auto-with-placeholder.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698