Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/components/ObjectPropertiesSection.js

Issue 2147343002: DevTools: cleanup treeoutline expand logic (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/ui/treeoutline.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All Rights Reserved. 2 * Copyright (C) 2008 Apple Inc. All Rights Reserved.
3 * Copyright (C) 2009 Joseph Pecoraro 3 * Copyright (C) 2009 Joseph Pecoraro
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 566 matching lines...) Expand 10 before | Expand all | Expand 10 after
577 } 577 }
578 } else { 578 } else {
579 property.parentObject = value; 579 property.parentObject = value;
580 treeNode.appendChild(new WebInspector.ObjectPropertyTreeElement(prop erty, linkifier)); 580 treeNode.appendChild(new WebInspector.ObjectPropertyTreeElement(prop erty, linkifier));
581 } 581 }
582 } 582 }
583 if (internalProperties) { 583 if (internalProperties) {
584 for (var i = 0; i < internalProperties.length; i++) { 584 for (var i = 0; i < internalProperties.length; i++) {
585 internalProperties[i].parentObject = value; 585 internalProperties[i].parentObject = value;
586 var treeElement = new WebInspector.ObjectPropertyTreeElement(interna lProperties[i], linkifier); 586 var treeElement = new WebInspector.ObjectPropertyTreeElement(interna lProperties[i], linkifier);
587 if (internalProperties[i].name === "[[Entries]]") { 587 treeNode.appendChild(treeElement);
588 treeElement.setExpandable(true); 588 if (internalProperties[i].name === "[[Entries]]")
589 treeElement.expand(); 589 treeElement.expand();
590 }
591 treeNode.appendChild(treeElement);
592 } 590 }
593 } 591 }
594 if (value && value.type === "function") { 592 if (value && value.type === "function") {
595 // Whether function has TargetFunction internal property. 593 // Whether function has TargetFunction internal property.
596 // This is a simple way to tell that the function is actually a bound fu nction (we are not told). 594 // This is a simple way to tell that the function is actually a bound fu nction (we are not told).
597 // Bound function never has inner scope and doesn't need corresponding U I node. 595 // Bound function never has inner scope and doesn't need corresponding U I node.
598 var hasTargetFunction = false; 596 var hasTargetFunction = false;
599 597
600 if (internalProperties) { 598 if (internalProperties) {
601 for (var i = 0; i < internalProperties.length; i++) { 599 for (var i = 0; i < internalProperties.length; i++) {
(...skipping 782 matching lines...) Expand 10 before | Expand all | Expand 10 after
1384 1382
1385 result = currentName + (result ? "." + result : ""); 1383 result = currentName + (result ? "." + result : "");
1386 current = current.parent; 1384 current = current.parent;
1387 } 1385 }
1388 var treeOutlineId = treeElement.treeOutline[WebInspector.ObjectPropertie sSectionExpandController._treeOutlineId]; 1386 var treeOutlineId = treeElement.treeOutline[WebInspector.ObjectPropertie sSectionExpandController._treeOutlineId];
1389 result = treeOutlineId + (result ? ":" + result : ""); 1387 result = treeOutlineId + (result ? ":" + result : "");
1390 treeElement[WebInspector.ObjectPropertiesSectionExpandController._cached PathSymbol] = result; 1388 treeElement[WebInspector.ObjectPropertiesSectionExpandController._cached PathSymbol] = result;
1391 return result; 1389 return result;
1392 } 1390 }
1393 } 1391 }
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/ui/treeoutline.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698