Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 2147333002: Re-reland: Add MemoryCoordinator (Closed)

Created:
4 years, 5 months ago by bashi
Modified:
4 years, 5 months ago
Reviewers:
haraken, chrisha, jam, dcheng
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, creis+watch_chromium.org, qsr+mojo_chromium.org, droger+watchlist_chromium.org, viettrungluu+watch_chromium.org, blundell+watchlist_chromium.org, sdefresne+watchlist_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-reland: Add MemoryCoordinator This is third attempt. `git cl try` doesn't help me :( Original description: This CL adds MemoryCoordinator mojo interface and its implementation. When --enable-features=MemoryCoordinator is specified the browser and renderers create their MemoryCoordinators. MemoryCoordinatorImpl (which lives in the browser process) creates a mojo message pipe when a renderer is launched. This CL doesn't add actual handling of memory events, which will be implemented in follow-up CLs. BUG=617492 TBR=chrisha@chromium.org,haraken@chromium.org,dcheng@chromium.org,jam@chromium.org Committed: https://crrev.com/c9dbbe31830fb0bc3014c21885880f3977323578 Cr-Commit-Position: refs/heads/master@{#405646}

Patch Set 1 #

Patch Set 2 : diff (attempt to fix GYP) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+343 lines, -33 lines) Patch
M components/memory_coordinator.gypi View 1 3 chunks +21 lines, -1 line 0 comments Download
M components/memory_coordinator/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
A + components/memory_coordinator/browser/BUILD.gn View 1 chunk +9 lines, -3 lines 0 comments Download
A components/memory_coordinator/browser/memory_coordinator.h View 1 chunk +42 lines, -0 lines 0 comments Download
A components/memory_coordinator/browser/memory_coordinator.cc View 1 chunk +56 lines, -0 lines 0 comments Download
M components/memory_coordinator/child/BUILD.gn View 1 chunk +5 lines, -1 line 0 comments Download
M components/memory_coordinator/child/child_memory_coordinator_impl.h View 2 chunks +14 lines, -6 lines 0 comments Download
M components/memory_coordinator/child/child_memory_coordinator_impl.cc View 1 chunk +19 lines, -5 lines 0 comments Download
M components/memory_coordinator/child/child_memory_coordinator_impl_unittest.cc View 5 chunks +15 lines, -17 lines 0 comments Download
M components/memory_coordinator/common/BUILD.gn View 1 chunk +6 lines, -0 lines 0 comments Download
A components/memory_coordinator/common/memory_coordinator_features.h View 1 chunk +24 lines, -0 lines 0 comments Download
A components/memory_coordinator/common/memory_coordinator_features.cc View 1 chunk +24 lines, -0 lines 0 comments Download
M components/memory_coordinator/public/interfaces/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A components/memory_coordinator/public/interfaces/memory_coordinator.mojom View 1 chunk +14 lines, -0 lines 0 comments Download
M content/browser/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/DEPS View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/browser_main_loop.h View 3 chunks +9 lines, -0 lines 0 comments Download
M content/browser/browser_main_loop.cc View 3 chunks +7 lines, -0 lines 0 comments Download
A content/browser/memory/memory_coordinator_browsertest.cc View 1 chunk +36 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 3 chunks +14 lines, -0 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M content/content_renderer.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M content/content_tests.gypi View 2 chunks +2 lines, -0 lines 0 comments Download
M content/renderer/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/render_thread_impl.h View 2 chunks +6 lines, -0 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 2 chunks +10 lines, -0 lines 0 comments Download
M content/test/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
bashi
Third attempt... (sorry for the noise again)
4 years, 5 months ago (2016-07-15 00:28:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2147333002/20001
4 years, 5 months ago (2016-07-15 00:29:32 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-15 00:35:17 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-15 00:35:35 UTC) #9
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/c9dbbe31830fb0bc3014c21885880f3977323578 Cr-Commit-Position: refs/heads/master@{#405646}
4 years, 5 months ago (2016-07-15 00:37:58 UTC) #11
haraken
LGTM
4 years, 5 months ago (2016-07-15 00:54:49 UTC) #12
bashi
4 years, 5 months ago (2016-07-15 01:05:50 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2152713003/ by bashi@chromium.org.

The reason for reverting is: GYP!!!.

Powered by Google App Engine
This is Rietveld 408576698