Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Issue 214733002: Fix the remaining issue of seperating WebGL from the default share group (Closed)

Created:
6 years, 9 months ago by Jun Jiang
Modified:
6 years, 8 months ago
CC:
blink-reviews, jamesr, krit, dsinclair, jbroman, danakj, Rik, Stephen Chennney, pdr., rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Fix the remaining issue of seperating WebGL from the default share group BUG=351956 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170292

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -2 lines) Patch
M Source/platform/graphics/gpu/DrawingBuffer.cpp View 2 chunks +27 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Jun Jiang
Please help to take a look. Thanks.
6 years, 9 months ago (2014-03-27 13:50:40 UTC) #1
bajones
On 2014/03/27 13:50:40, Jun Jiang wrote: > Please help to take a look. Thanks. Non-Owner ...
6 years, 9 months ago (2014-03-27 16:08:44 UTC) #2
Ken Russell (switch to Gerrit)
Very nice. Thank you for tracking this down. LGTM Agree with Brandon that it would ...
6 years, 8 months ago (2014-03-27 18:53:25 UTC) #3
dshwang
non-owner LGTM. I'm sure this code path is used by printing.
6 years, 8 months ago (2014-03-27 21:21:24 UTC) #4
dshwang
This code path might be used when software canvas draws webgl or when software canvas ...
6 years, 8 months ago (2014-03-27 21:32:09 UTC) #5
junj
The CQ bit was checked by jun.a.jiang@chromium.org
6 years, 8 months ago (2014-03-28 06:50:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jun.a.jiang@intel.com/214733002/1
6 years, 8 months ago (2014-03-28 06:50:50 UTC) #7
commit-bot: I haz the power
6 years, 8 months ago (2014-03-28 07:54:46 UTC) #8
Message was sent while issue was closed.
Change committed as 170292

Powered by Google App Engine
This is Rietveld 408576698