Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 2147303003: Update layout at required place in InputMethodController::setComposition() (Closed)

Created:
4 years, 5 months ago by yosin_UTC9
Modified:
4 years, 5 months ago
Reviewers:
yoichio
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update layout at required place in InputMethodController::setComposition() This patch moves update layout call before |mostForwardCaretPosition()| which requires clean layout tree as a preparation of introducing clean layout tree assertion to |mostForwardCaretPosition()|. BUG=590369 TEST=n/a; no behavior changes Committed: https://crrev.com/0b978a76df0769725e3e16c39bfa507fc50479b7 Cr-Commit-Position: refs/heads/master@{#406246}

Patch Set 1 : 2016-07-15T16:00:21 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M third_party/WebKit/Source/core/editing/InputMethodController.cpp View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
yosin_UTC9
PTAL
4 years, 5 months ago (2016-07-15 08:22:39 UTC) #7
yoichio
lgtm
4 years, 5 months ago (2016-07-19 06:22:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2147303003/1
4 years, 5 months ago (2016-07-19 08:20:14 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-19 11:17:39 UTC) #11
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-19 11:17:44 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-19 11:20:51 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0b978a76df0769725e3e16c39bfa507fc50479b7
Cr-Commit-Position: refs/heads/master@{#406246}

Powered by Google App Engine
This is Rietveld 408576698