Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 214723003: Add an unimplemented history API to WebView (Closed)

Created:
6 years, 9 months ago by Nate Chapin
Modified:
6 years, 8 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium, site-isolation-reviews_chromium.org
Visibility:
Public.

Description

Add an unimplemented history API to WebView This API will function as a temporary shim to enable history functionality to move to content/renderer, without any broken intermediate steps. This is step 1 of 5 from http://crbug.com/357327 BUG=357327 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170488

Patch Set 1 #

Total comments: 2

Patch Set 2 : +WebHisotryCommitType descriptions #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -4 lines) Patch
M Source/web/AssertMatchingEnums.cpp View 3 chunks +7 lines, -0 lines 0 comments Download
M Source/web/WebFrameImpl.cpp View 1 chunk +7 lines, -4 lines 0 comments Download
M public/web/WebFrameClient.h View 1 2 chunks +5 lines, -0 lines 0 comments Download
A public/web/WebHistoryCommitType.h View 1 1 chunk +29 lines, -0 lines 0 comments Download
M public/web/WebView.h View 2 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Nate Chapin
6 years, 9 months ago (2014-03-27 21:45:13 UTC) #1
abarth-chromium
lgtm https://codereview.chromium.org/214723003/diff/1/public/web/WebHistoryCommitType.h File public/web/WebHistoryCommitType.h (right): https://codereview.chromium.org/214723003/diff/1/public/web/WebHistoryCommitType.h#newcode15 public/web/WebHistoryCommitType.h:15: }; Can you add some comments explaining what ...
6 years, 9 months ago (2014-03-27 23:00:46 UTC) #2
Nate Chapin
https://codereview.chromium.org/214723003/diff/1/public/web/WebHistoryCommitType.h File public/web/WebHistoryCommitType.h (right): https://codereview.chromium.org/214723003/diff/1/public/web/WebHistoryCommitType.h#newcode15 public/web/WebHistoryCommitType.h:15: }; On 2014/03/27 23:00:47, abarth wrote: > Can you ...
6 years, 9 months ago (2014-03-27 23:27:05 UTC) #3
Nate Chapin
The CQ bit was checked by japhet@chromium.org
6 years, 8 months ago (2014-03-31 20:42:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/japhet@chromium.org/214723003/20001
6 years, 8 months ago (2014-03-31 20:43:49 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-31 21:58:11 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 8 months ago (2014-03-31 21:58:11 UTC) #7
Nate Chapin
The CQ bit was checked by japhet@chromium.org
6 years, 8 months ago (2014-03-31 21:58:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/japhet@chromium.org/214723003/20001
6 years, 8 months ago (2014-03-31 21:58:40 UTC) #9
commit-bot: I haz the power
6 years, 8 months ago (2014-03-31 23:59:17 UTC) #10
Message was sent while issue was closed.
Change committed as 170488

Powered by Google App Engine
This is Rietveld 408576698