Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2147223005: [Android] Add upstream version of studio doc. (Closed)

Created:
4 years, 5 months ago by jbudorick
Modified:
4 years, 3 months ago
Reviewers:
agrieve
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Add upstream version of studio doc. BUG= Committed: https://crrev.com/900a8d837a57d61eaa2092d67e5d887a3c3468ec Cr-Commit-Position: refs/heads/master@{#406050}

Patch Set 1 #

Total comments: 4

Patch Set 2 : agrieve comments #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -0 lines) Patch
A docs/android_studio.md View 1 1 chunk +43 lines, -0 lines 2 comments Download

Messages

Total messages: 13 (4 generated)
jbudorick
4 years, 5 months ago (2016-07-15 18:29:56 UTC) #2
agrieve
lgtm. THanks for doing this! https://codereview.chromium.org/2147223005/diff/1/docs/android_studio.md File docs/android_studio.md (right): https://codereview.chromium.org/2147223005/diff/1/docs/android_studio.md#newcode21 docs/android_studio.md:21: ### Roadmap / what's ...
4 years, 5 months ago (2016-07-18 16:47:28 UTC) #3
jbudorick
https://codereview.chromium.org/2147223005/diff/1/docs/android_studio.md File docs/android_studio.md (right): https://codereview.chromium.org/2147223005/diff/1/docs/android_studio.md#newcode21 docs/android_studio.md:21: ### Roadmap / what's not yet implemented On 2016/07/18 ...
4 years, 5 months ago (2016-07-18 17:59:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2147223005/20001
4 years, 5 months ago (2016-07-18 17:59:58 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-18 18:56:23 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-18 18:56:33 UTC) #9
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/900a8d837a57d61eaa2092d67e5d887a3c3468ec Cr-Commit-Position: refs/heads/master@{#406050}
4 years, 5 months ago (2016-07-18 18:58:47 UTC) #11
johnme
https://codereview.chromium.org/2147223005/diff/20001/docs/android_studio.md File docs/android_studio.md (right): https://codereview.chromium.org/2147223005/diff/20001/docs/android_studio.md#newcode37 docs/android_studio.md:37: - Launch it with more RAM: `STUDIO_VM_OPTIONS=-Xmx2048m /opt/android-studio-stable/bin/studio-launcher.sh` It ...
4 years, 4 months ago (2016-08-16 14:47:51 UTC) #12
agrieve
4 years, 3 months ago (2016-08-30 19:57:54 UTC) #13
Message was sent while issue was closed. 
https://codereview.chromium.org/2147223005/diff/20001/docs/android_studio.md
File docs/android_studio.md (right):

https://codereview.chromium.org/2147223005/diff/20001/docs/android_studio.md#...
docs/android_studio.md:37: - Launch it with more RAM:
`STUDIO_VM_OPTIONS=-Xmx2048m /opt/android-studio-stable/bin/studio-launcher.sh`
On 2016/08/16 14:47:51, johnme wrote:
> It seems STUDIO_VM_OPTIONS has to be a file according to
> http://tools.android.com/tech-docs/configuration and all the other examples I
> can find

Might be a better idea, but looking at studio.sh, it does actually work as an
environment var.

Powered by Google App Engine
This is Rietveld 408576698