Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1444)

Issue 2147223004: SELECT element: Remove HTMLSelectElement::optionToListIndex(). (Closed)

Created:
4 years, 5 months ago by tkent
Modified:
4 years, 5 months ago
Reviewers:
keishi
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

SELECT element: Remove HTMLSelectElement::optionToListIndex(). Remove two instances of optionToListIndex() callsites, and remove optionToListIndex(). * HTMLSelectElement::hasPlaceholderLabelOption(): optionToListIndex() was just redundant. We need to check just isHTMLOptionElement(listItems()[0]). * HTMLSelectElement::remove(): We can use item() to get an OPTION at the specified index. This CL has no behavior changes. Committed: https://crrev.com/8f6281da70545e44a3445840e05a24ae79498e8f Cr-Commit-Position: refs/heads/master@{#405690}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -27 lines) Patch
M third_party/WebKit/Source/core/html/HTMLSelectElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLSelectElement.cpp View 3 chunks +6 lines, -26 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
tkent
Keishi, would you review this please?
4 years, 5 months ago (2016-07-15 02:24:54 UTC) #4
keishi
LGTM
4 years, 5 months ago (2016-07-15 02:27:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2147223004/1
4 years, 5 months ago (2016-07-15 03:29:28 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-15 03:33:41 UTC) #11
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-15 03:33:50 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-15 03:35:09 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8f6281da70545e44a3445840e05a24ae79498e8f
Cr-Commit-Position: refs/heads/master@{#405690}

Powered by Google App Engine
This is Rietveld 408576698