Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Issue 2147213004: Revert of [ic] [stubs] Don't use Code::flags in megamorphic stub cache hash computations. (Closed)

Created:
4 years, 5 months ago by Igor Sheludko
Modified:
4 years, 5 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@split-stub-cache
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [ic] [stubs] Don't use Code::flags in megamorphic stub cache hash computations. (patchset #2 id:20001 of https://codereview.chromium.org/2147433002/ ) Reason for revert: Unfortunately, the performance issues are still there on Android. Original issue's description: > [ic] [stubs] Don't use Code::flags in megamorphic stub cache hash computations. > > This should avoid weird performance issues when changing layout of Code::flags field. > > BUG=chromium:618701 > > Committed: https://crrev.com/aa4140b1ccc114b82700471513c715f68b7c5dac > Cr-Commit-Position: refs/heads/master@{#37755} TBR=jkummerow@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:618701 Committed: https://crrev.com/e6b3002a613da0aa63d039e9629a3688825d22d3 Cr-Commit-Position: refs/heads/master@{#37801}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+261 lines, -152 lines) Patch
M src/code-stub-assembler.h View 2 chunks +5 lines, -3 lines 0 comments Download
M src/code-stub-assembler.cc View 6 chunks +29 lines, -14 lines 0 comments Download
M src/code-stubs.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/ic/arm/stub-cache-arm.cc View 4 chunks +15 lines, -9 lines 0 comments Download
M src/ic/arm64/stub-cache-arm64.cc View 4 chunks +13 lines, -11 lines 0 comments Download
M src/ic/ia32/stub-cache-ia32.cc View 7 chunks +17 lines, -13 lines 0 comments Download
M src/ic/ic.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/ic/mips/stub-cache-mips.cc View 4 chunks +13 lines, -9 lines 0 comments Download
M src/ic/mips64/stub-cache-mips64.cc View 4 chunks +13 lines, -9 lines 0 comments Download
M src/ic/ppc/stub-cache-ppc.cc View 5 chunks +13 lines, -9 lines 0 comments Download
M src/ic/s390/stub-cache-s390.cc View 5 chunks +13 lines, -9 lines 0 comments Download
M src/ic/stub-cache.h View 4 chunks +22 lines, -12 lines 0 comments Download
M src/ic/stub-cache.cc View 6 chunks +33 lines, -18 lines 0 comments Download
M src/ic/x64/stub-cache-x64.cc View 4 chunks +12 lines, -7 lines 0 comments Download
M src/ic/x87/stub-cache-x87.cc View 7 chunks +17 lines, -13 lines 0 comments Download
M src/type-info.h View 1 chunk +4 lines, -2 lines 0 comments Download
M src/type-info.cc View 3 chunks +9 lines, -4 lines 0 comments Download
M test/cctest/test-code-stub-assembler.cc View 6 chunks +31 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Igor Sheludko
Created Revert of [ic] [stubs] Don't use Code::flags in megamorphic stub cache hash computations.
4 years, 5 months ago (2016-07-15 16:07:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2147213004/1
4 years, 5 months ago (2016-07-15 16:07:36 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-15 17:19:39 UTC) #4
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-15 17:19:41 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-07-15 17:22:00 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e6b3002a613da0aa63d039e9629a3688825d22d3
Cr-Commit-Position: refs/heads/master@{#37801}

Powered by Google App Engine
This is Rietveld 408576698